Skip to content

Conversation

@liguohui-lgh
Copy link
Contributor

What is this PR for?

unique() algorithm is not correct in pivot.js file.
If the input is [2, 3, 3, 3, 4, 5] and the output will be [2, 3, 3, 4, 5]. The number 3 is still duplicated.

What type of PR is it?

[Bug Fix]

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-3075 [ZEPPELIN-3075]

How should this be tested?

Added unit test. Added screenshots for test.

Screenshots (if appropriate)

untitled project
201711240311281511507488261_small

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@tinkoff-dwh
Copy link
Contributor

why another PR? #2685

@liguohui-lgh
Copy link
Contributor Author

I don't know why the jenkins is failed for #2685.
The error tip is:

Looks like travis-ci is not configured for your fork.
Please setup by swich on 'zeppelin' repository at https://travis-ci.org/profile and travis-ci.

But my fork is copied from master. There is .travis.yml in the fork project.
I cannot find the commit message in https://travis-ci.org/profile and the JSON from https://api.travis-ci.org/repos/liguohuicmss/zeppelin/builds is empty.

@tinkoff-dwh
Copy link
Contributor

tinkoff-dwh commented Nov 28, 2017

close this PR.
read https://zeppelin.apache.org/contribution/contributions.html#continuous-integration
you should setting travis-ci to work with your fork (sign-in by Github, add repository (your fork))
after that your changes (in liguohuicmss:pivot-unqiue-algo) will start the build in travis-ci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants