[ZEPPELIN-3075]Fix unqiue algo for the web side in pivot.js file.#1
Merged
liguohui-lgh merged 4 commits intomasterfrom Nov 28, 2017
Merged
[ZEPPELIN-3075]Fix unqiue algo for the web side in pivot.js file.#1liguohui-lgh merged 4 commits intomasterfrom
liguohui-lgh merged 4 commits intomasterfrom
Conversation
added 4 commits
November 23, 2017 21:28
…oups' and 'values'" This reverts commit f996747.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
unique() algorithm is not correct in pivot.js file.
If the input is
[2, 3, 3, 3, 4, 5]and the output will be[2, 3, 3, 4, 5]. The number3is still duplicated.What type of PR is it?
[Bug Fix]
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-3075 [ZEPPELIN-3075]
How should this be tested?
Added unit test. Added Screenshots for the test.
Screenshots (if appropriate)
Questions: