Skip to content

Conversation

@tinkoff-dwh
Copy link
Contributor

What is this PR for?

Fix build interpreters (apark and R) which broken after #2592 and
#2596

What type of PR is it?

[Hot Fix]

How should this be tested?

build interpreters

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no

@tinkoff-dwh
Copy link
Contributor Author

@necosta @zjffdu @felixcheung
pls help with review

@jongyoul
Copy link
Member

LGTM. I'll merge it as a hotfix. BTW, I think it would be better to divide two different PR by fixing bug and refactoring somethings.

@asfgit asfgit closed this in 6d590c4 Oct 24, 2017
@felixcheung
Copy link
Member

felixcheung commented Oct 24, 2017 via email

@zjffdu
Copy link
Contributor

zjffdu commented Oct 25, 2017

Thanks @tinkoff-dwh for fixing this. Could you let me know how SparkRInterpreter is broken, I am curious to know why our CI didn't catch this.

@jongyoul
Copy link
Member

I’m also curious about it. It’s very basic error when compiling without symbol.

@tinkoff-dwh
Copy link
Contributor Author

tinkoff-dwh commented Oct 25, 2017

@jongyoul @zjffdu
after merge #2596
https://github.com/apache/zeppelin/pull/2596/files#diff-dbda0c4083ad9c59ff05f0273b5e760fR935

property.getProperty...

This PR has no changes from #2592 and added string with property..

@jongyoul
Copy link
Member

Yes, what I wondered is how that PR passed our CI. property doesn't exist in the class and it shouldn't have passed CI. May we have a hole on our CI?

@tinkoff-dwh
Copy link
Contributor Author

tinkoff-dwh commented Oct 25, 2017

@jongyoul
In CI all ok, because branch of PR has field property ad has no conflicts with branch master. After merge jobs falls (CI, branch master) https://travis-ci.org/apache/zeppelin/builds/291922211?utm_source=github_status&utm_medium=notification

@jongyoul
Copy link
Member

Yes, I know the current situation and this PR solves what kind of problem, but our merge script uses squash merge from PR branch and it means if that PR branch has property in that branch, it would have been merged by our merge script, otherwise if that PR branch doesn't have property in that branch, CI would fail. But AFAIK, that branch doesn't have property but CI passed. I just wanted to know how it happens.

@tinkoff-dwh tinkoff-dwh deleted the fix_r_interpretator branch October 26, 2017 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants