[ZEPPELIN-2949] Allow custom Spark UI URL #2596
Conversation
felixcheung
left a comment
felixcheung
left a comment
There was a problem hiding this comment.
seems like a reasonable approach
there's one test failure, could you check?
|
Thanks @felixcheung. Test looks unrelated but I'll double check. Not sure how much we want to document on how to work with Spark behind reverse proxy but I can add that by setting properties we have a working solution:
https://issues.apache.org/jira/browse/SPARK-20044 is preventing us from using a path prefix and it is assumed we are routing from spark port to reverseProxyUniqueKey |
|
Not sure what we can do to have the tests passing: |
There was a problem hiding this comment.
test failures looks to be unrelated (sorry typo), but could you rebase your PR and try tests again?
testGetFactory(org.apache.zeppelin.interpreter.InterpreterFactoryTest) Time elapsed: 0.584 sec <<< FAILURE!
org.junit.ComparisonFailure: expected:<...eppelin.interpreter.[EchoInterpreter]> but was:<...eppelin.interpreter.[mock.MockInterpreter1]>
docs/interpreter/spark.md
Outdated
| <tr> | ||
| <td>zeppelin.spark.uiWebUrl</td> | ||
| <td></td> | ||
| <td>Override Spark UI default URL</td> |
There was a problem hiding this comment.
could you add a bit more on what are the condition to set this, example value etc..?
|
Thanks @felixcheung and apologies for the delay on this. |
felixcheung
left a comment
felixcheung
left a comment
There was a problem hiding this comment.
great, sorry a few minor comment I missed the last time
docs/interpreter/spark.md
Outdated
| <tr> | ||
| <td>zeppelin.spark.uiWebUrl</td> | ||
| <td></td> | ||
| <td>Overrides Spark UI default URL (ex: http://{hostName}/{uniquePath)</td> |
There was a problem hiding this comment.
should this be {uniquePath) -> {uniquePath})
There was a problem hiding this comment.
I think we should clarify that the value should be a full URL
There was a problem hiding this comment.
Fixed on latest commit
| } | ||
|
|
||
| String sparkUrlProp = property.getProperty("zeppelin.spark.uiWebUrl", ""); | ||
| if (!sparkUrlProp.isEmpty()) { |
There was a problem hiding this comment.
There was a problem hiding this comment.
I agree. Fixed on latest commit
|
merging if no more comment |
### What is this PR for? Fix build interpreters (apark and R) which broken after apache#2592 and apache#2596 ### What type of PR is it? [Hot Fix] ### How should this be tested? build interpreters ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: tinkoff-dwh <tinkoff.dwh@gmail.com> Closes apache#2630 from tinkoff-dwh/fix_r_interpretator and squashes the following commits: 0c9828b [tinkoff-dwh] [HOTFIX] fix build spark and R interpreters
2 participants
What is this PR for?
Allow an override of default Spark logic in building the URL path and redirect the Zeppelin user directly to a configured reverse proxy path
What type of PR is it?
[Improvement]
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: