Skip to content

[FIX] fix converter forms to json #2623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tinkoff-dwh wants to merge 4 commits into from
Closed

[FIX] fix converter forms to json #2623

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
17ec2db
[FIX] fix converter forms to json
tinkoff-dwh Oct 14, 2017
b841550
[FIX] refactoring of context converter. add test to check converter o…
tinkoff-dwh Oct 15, 2017
08cf921
[FIX] checkstyle
tinkoff-dwh Oct 15, 2017
fdb6cfe
[FIX] checkstyle
tinkoff-dwh Oct 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
package org.apache.zeppelin.interpreter.remote;

import com.google.gson.Gson;
import com.google.gson.GsonBuilder;
import com.google.gson.reflect.TypeToken;
import org.apache.thrift.TException;
import org.apache.zeppelin.conf.ZeppelinConfiguration;
Expand Down Expand Up @@ -54,7 +55,9 @@
*/
public class RemoteInterpreter extends Interpreter {
private static final Logger LOGGER = LoggerFactory.getLogger(RemoteInterpreter.class);
private static final Gson gson = new Gson();
private static final Gson gson = new GsonBuilder()
.registerTypeAdapterFactory(Input.TypeAdapterFactory)
.create();


private String className;

@zjffdu zjffdu Oct 15, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you just use gui.toJson() in L394 ?

Expand Down