-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[FIX] fix converter forms to json #2623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| .create(); | ||
|
|
||
|
|
||
| private String className; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you just use gui.toJson() in L394 ?
felixcheung
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there any test for this, if not, can we add one?
|
@zjffdu @felixcheung |
|
is test failure related? |
|
nope |
felixcheung
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok looks good, any more comment?
|
merge? |
What is this PR for?
Fix converter for forms
What type of PR is it?
[Bug Fix]
How should this be tested?
jdbc
select '${checkbox:name=1|2,first|second}'Screenshots (if appropriate)
before

after

Questions: