Skip to content

Conversation

@tinkoff-dwh
Copy link
Contributor

What is this PR for?

Fix converter for forms

What type of PR is it?

[Bug Fix]

How should this be tested?

jdbc

  1. select '${checkbox:name=1|2,first|second}'

Screenshots (if appropriate)

before
before

after
after

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no

.create();


private String className;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you just use gui.toJson() in L394 ?

Copy link
Member

@felixcheung felixcheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any test for this, if not, can we add one?

@tinkoff-dwh
Copy link
Contributor Author

@zjffdu @felixcheung
done

@felixcheung
Copy link
Member

is test failure related?

15:11:43,740  INFO org.apache.zeppelin.spark.SparkInterpreter:979 - Sending metadata to Zeppelin server: {message=Spark UI enabled, url=http://10.20.0.79:4040}
<console>:24: error: not found: value value
       def category(min: Int) = {    if (0 <= value) "error"}
                                              ^
15:11:43,772 DEBUG org.apache.zeppelin.interpreter.Interpreter:197 - key: spark.ui.enabled, value: true
15:11:43,773  INFO org.apache.zeppelin.spark.SparkInterpreter:979 - Sending metadata to Zeppelin server: {message=Spark UI enabled, url=http://10.20.0.79:4040}
defined class Person
15:11:44,112 ERROR org.apache.zeppelin.spark.SparkInterpreter:1256 - 
java.lang.NullPointerException
	at scala.tools.nsc.interpreter.IMain$ReadEvalPrint.call(IMain.scala:784)

@tinkoff-dwh
Copy link
Contributor Author

nope

Copy link
Member

@felixcheung felixcheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok looks good, any more comment?

@tinkoff-dwh
Copy link
Contributor Author

merge?

@asfgit asfgit closed this in 30f6024 Oct 26, 2017
@tinkoff-dwh tinkoff-dwh deleted the forms-fix branch October 30, 2017 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants