Skip to content

[HOTFIX] Remove adduser while creating note #2292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jongyoul wants to merge 1 commit into from
Closed

[HOTFIX] Remove adduser while creating note #2292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Note.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,6 @@ public Paragraph insertNewParagraph(int index, AuthenticationInfo authentication
private Paragraph createParagraph(int index, AuthenticationInfo authenticationInfo) {
Paragraph p = new Paragraph(this, this, factory, interpreterSettingManager);
p.setAuthenticationInfo(authenticationInfo);
p.addUser(p, p.getUser());
setParagraphMagic(p, index);
return p;
}
Expand Down
16 changes: 16 additions & 0 deletions zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NoteTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,4 +217,20 @@ public void getNameWithoutNameItself() {

assertEquals("getName should return same as getId when name is empty", note.getId(), note.getName());
}

@Test
public void personalizedModeReturnDifferentParagraphInstancePerUser() {
Note note = new Note(repo, interpreterFactory, interpreterSettingManager, jobListenerFactory, index, credentials, noteEventListener);

String user1 = "user1";
String user2 = "user2";
note.setPersonalizedMode(true);
note.addNewParagraph(new AuthenticationInfo(user1));
Paragraph baseParagraph = note.getParagraphs().get(0);
Paragraph user1Paragraph = baseParagraph.getUserParagraph(user1);
Paragraph user2Paragraph = baseParagraph.getUserParagraph(user2);
assertNotEquals(System.identityHashCode(baseParagraph), System.identityHashCode(user1Paragraph));
assertNotEquals(System.identityHashCode(baseParagraph), System.identityHashCode(user2Paragraph));
assertNotEquals(System.identityHashCode(user1Paragraph), System.identityHashCode(user2Paragraph));
}
}