Skip to content

Conversation

@jongyoul
Copy link
Member

What is this PR for?

Adding user paragraph while creating paragraph makes default paragraph and user paragraph have same reference. It breaks personalized mode works well.

What type of PR is it?

[Bug Fix | Hot Fix]

Todos

  • - Remove addUser from createParagraph
  • - Add test case for it

What is the Jira issue?

N/A

How should this be tested?

N/A

Screenshots (if appropriate)

N/A

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

Added test to guarantee paragraph.getUserParagraph is different from paragraph itself
@Leemoonsoo
Copy link
Member

LGTM

@jongyoul jongyoul changed the title [HOTFIX] Removed adduser while creating note [HOTFIX] Remove adduser while creating note Apr 26, 2017
@jongyoul jongyoul closed this Apr 27, 2017
@jongyoul jongyoul reopened this Apr 27, 2017
@jongyoul jongyoul closed this May 4, 2017
@jongyoul jongyoul reopened this May 4, 2017
@asfgit asfgit closed this in 6db9929 May 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants