[ZEPPELIN-1461] Doesn't display "description" value in interpreter creation page #1559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
\cc @jongyoul @cloverhearts @kjhong for review |
minahlee
force-pushed
the
ZEPPELIN-1461
branch
3 times, most recently
from
2c99cec to
a02421c
Compare
Contributor
|
Tested on local LGTM. |
Member
|
LGTM. Please rebase it. |
minahlee
force-pushed
the
ZEPPELIN-1461
branch
2 times, most recently
from
22a27ea to
93e45a0
Compare
minahlee
force-pushed
the
ZEPPELIN-1461
branch
from
93e45a0 to
4a278f0
Compare
Member
Author
|
@jongyoul Done :) |
Member
|
Tested. |
Member
|
I'll merge it. |
asfgit
pushed a commit
that referenced
this pull request
Nov 2, 2016
darionyaphet
pushed a commit
to darionyaphet/zeppelin
that referenced
this pull request
Nov 4, 2016
…eation page ### What is this PR for? apache#1522 tried to fix same issue by making as least change as possible, but fixing it in backend side looks like more proper approach as apache#1522 (comment). This PR fixes ZEPPELIN-1461 by changing `properties` field of `InterpreterSetting` class from `Properties` -> `Object`. ### What type of PR is it? Bug Fix ### What is the Jira issue? [ZEPPELIN-1461](https://issues.apache.org/jira/browse/ZEPPELIN-1461) ### Screenshots (if appropriate) Before  After  ### Questions: - Does the licenses files need update? no - Is there breaking changes for older versions? no - Does this needs documentation? no Author: Mina Lee <[email protected]> Closes apache#1559 from minahlee/ZEPPELIN-1461 and squashes the following commits: 4a278f0 [Mina Lee] Add test checking InterpreterProperty class 14a6300 [Mina Lee] Add selenium test for display description on interpreter create 4eba177 [Mina Lee] Fix order of properties in ui and java code style 1a2a41d [Mina Lee] Show description when create new interpreter
darionyaphet
pushed a commit
to darionyaphet/zeppelin
that referenced
this pull request
Nov 4, 2016
…eation page ### What is this PR for? apache#1522 tried to fix same issue by making as least change as possible, but fixing it in backend side looks like more proper approach as apache#1522 (comment). This PR fixes ZEPPELIN-1461 by changing `properties` field of `InterpreterSetting` class from `Properties` -> `Object`. ### What type of PR is it? Bug Fix ### What is the Jira issue? [ZEPPELIN-1461](https://issues.apache.org/jira/browse/ZEPPELIN-1461) ### Screenshots (if appropriate) Before  After  ### Questions: - Does the licenses files need update? no - Is there breaking changes for older versions? no - Does this needs documentation? no Author: Mina Lee <[email protected]> Closes apache#1559 from minahlee/ZEPPELIN-1461 and squashes the following commits: 4a278f0 [Mina Lee] Add test checking InterpreterProperty class 14a6300 [Mina Lee] Add selenium test for display description on interpreter create 4eba177 [Mina Lee] Fix order of properties in ui and java code style 1a2a41d [Mina Lee] Show description when create new interpreter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
#1522 tried to fix same issue by making as least change as possible, but fixing it in backend side looks like more proper approach as #1522 (comment).
This PR fixes ZEPPELIN-1461 by changing
propertiesfield ofInterpreterSettingclass fromProperties->Object.What type of PR is it?
Bug Fix
What is the Jira issue?
ZEPPELIN-1461
Screenshots (if appropriate)
Before
After
Questions: