Add message of localhost:port on script #1472

kination · 2016-09-29T04:28:05Z

What is this PR for?

To show the localhost:port number info when running zeppelin.sh script.

What type of PR is it?

[Improvement]

Todos

- Task

What is the Jira issue?

Not an issue.

How should this be tested?

Run ./zeppelin.sh or ./zeppelin_daemon.sh and see the message about localhost is appearing.

AhyoungRyu · 2016-09-29T04:35:57Z

bin/zeppelin-daemon.sh

    $(mkdir -p "${ZEPPELIN_PID_DIR}")
  fi
+
+  echo "Browse localhost:8080 in your browser"


Hi @djKooks. Thanks for your contribution!

What if the users are not using localhost?

Fix to show public IP address or localhost

kination · 2016-09-29T05:42:24Z

@AhyoungRyu Oh, it was my mistake. Sorry for silly bugs.
I just updated script to find public IP.

AhyoungRyu · 2016-09-29T05:47:39Z

bin/zeppelin-daemon.sh


-  echo "Browse localhost:8080 in your browser"
+  IP_ADDR="$(ifconfig en0 | grep inet | grep -v inet6 | cut -d ' ' -f2)"
+  echo -e "Browse $IP_ADDR:8080 in your browser.\nIf you are testing on your local computer, use localhost:8080"


@djKooks As you can see in Apache Zeppelin Configuration, user can also change the server port using ZEPPELIN_PORT and zeppelin.server.port value. Can we update the port as well? Sorry about this. I should've told about it with my last comment.

@AhyoungRyu Thanks! Which file do I have to refer for this value? zeppelin-site.xml or zeppelin-env.sh or else?

@djKooks As you can see in the referred docs

You can configure Apache Zeppelin with either environment variables in conf/zeppelin-env.sh (conf\zeppelin-env.cmd for Windows) or Java properties in conf/zeppelin-site.xml. If both are defined, then the environment variables will take priority.

User can change the port using both zeppelin-site.xml and zeppelin-env.sh. If the user modify only zeppelin-env.sh or both, then you can easily refer zeppelin-env.sh file. But we should also cover the other case that only zeppelin-site.xml is changed.

@AhyoungRyu Okay. I'll check and update.

@AhyoungRyu I updated script to read port num from zeppelin-env.sh, but still have problem on reading from zeppelin-site.xml. There are some xml parser but needs additional parser to be installed, and that seems really not good.
How do you think about adding id for each nodes? Like below...

<configuration> <property> <name>zeppelin.server.addr</name> <value id="zeppelin.server.addr">0.0.0.0</value> <description>Server address</description> </property> <property> <name>zeppelin.server.port</name> <value id="zeppelin.server.port">8080</value> <description>Server port.</description> </property> ...

How do you think about it? This will cause no side effect as long as I know.
If you are not sure about it, I'll update this first so you could look through it carefully.

Yeah that would be possible approach I think.

If you are not sure about it, I'll update this first so you could look through it carefully.

Sounds good! :)

AhyoungRyu · 2016-09-29T05:50:47Z

@djKooks Yeah I just saw the commit right after you pushed. It's not a silly bug :) But the port part should be updated as well. Some users can use other port number not 8080. Could you check again please?

AhyoungRyu · 2016-10-07T07:43:15Z

@djKooks Sorry for my late response. Seems there is already similar feature merged few days ago. Could you please take a look at #1399? But it only print in the log files. I think you can use it. What do you think? :D

kination · 2016-10-09T12:58:10Z

@AhyoungRyu It looks different. The one in #1399 records ip address in log, but I want to show this during script is running. It seems ok to keep working on.

AhyoungRyu · 2016-10-09T13:07:38Z

@djKooks Yeah you're right. I left the comment like that at the first time, but I realized that it's different change after checking it again. Sorry for any confusion.

kination · 2016-10-10T07:24:41Z

@AhyoungRyu No problem~thanks for guide! I'll keep work on it.

Add attr name value on zeppelin-site template

kination · 2016-10-25T01:17:25Z

@AhyoungRyu Sorry for late reply.
I updated scripts to read port number from environment setups. Please look on and let me know if there is any problem on running this.

AhyoungRyu · 2016-10-25T08:17:47Z

@djKooks Thanks for kind reminder :)

Currently Zeppelin works with "zero-configuration" status. As you know, even if users didn't activate conf/zeppelin-env.sh.template or conf/zeppelin-site.xml.template, Zeppelin works with default configurations. I think you missed this side. Can you test this patch without zeppelin-env.sh and zeppelin-site.xml again?

Check status with no env file

check env file status

kination · 2016-10-25T08:39:46Z

@AhyoungRyu you're right. Thanks for comments. I just update lines for file check.

jongyoul · 2016-10-31T05:54:57Z

@djKooks Hi, Is there any issue for installing xmllint? I found it in Mac and Linux but I'm not sure if it exists in all of linux and mac. Do you have any idea?

AhyoungRyu · 2016-10-31T06:42:01Z

@djKooks Sorry for my late response.

Tested again and it works as expected only when I'm using wireless interpreter.
If I connected wired internet, it doesn't print host info as below

$ ./bin/zeppelin-daemon.sh restart
Zeppelin stop                                              [  OK  ]
Browse :8080 in your browser.
If you are testing on your local computer, use localhost:8080
Zeppelin start                                             [  OK  ]

Can you check again this?

AhyoungRyu · 2016-10-31T09:57:57Z

@djKooks And in my personal opinion, I wonder we need to print wireless network address in shell window since it changes depending on the user's network environment. What do you think?

kination · 2016-11-01T04:26:14Z

@AhyoungRyu Actually, I was also thinking about whether this commit needs now. I'll drop this issue and maybe look it again after when it seems useful.
Thanks for help.

AhyoungRyu · 2016-11-01T05:44:06Z

@djKooks Yeah right. Thanks for your consideration.
And please do not hesitate if you want to contribute to Zeppelin next time. All ppl in the community will help you!

kination · 2016-11-01T06:22:45Z

@AhyoungRyu Okay. Thanks~

Add message of localhost:port on script

fb9fa6c

AhyoungRyu reviewed Sep 29, 2016

View reviewed changes

kination added 2 commits September 29, 2016 14:40

Update zeppelin-daemon.sh

6cf34b9

Fix to show public IP address or localhost

Update zeppelin.sh

69364eb

Fix to show public IP address or localhost

AhyoungRyu reviewed Sep 29, 2016

View reviewed changes

kination added 3 commits October 25, 2016 10:12

Add attr name value

df4eea0

Add attr name value on zeppelin-site template

Update zeppelin-daemon.sh

e48ac8a

Update zeppelin.sh

9a7b1ab

kination added 2 commits October 25, 2016 17:37

Update zeppelin.sh

18c960b

Check status with no env file

Update zeppelin-daemon.sh

99154a2

check env file status

kination closed this Nov 1, 2016

Add message of localhost:port on script #1472

Add message of localhost:port on script #1472

Uh oh!

Conversation

kination commented Sep 29, 2016

What is this PR for?

What type of PR is it?

Todos

What is the Jira issue?

How should this be tested?

Uh oh!

AhyoungRyu Sep 29, 2016

Choose a reason for hiding this comment

Uh oh!

kination commented Sep 29, 2016

Uh oh!

AhyoungRyu Sep 29, 2016

Choose a reason for hiding this comment

Uh oh!

kination Sep 29, 2016

Choose a reason for hiding this comment

Uh oh!

AhyoungRyu Sep 29, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kination Sep 29, 2016

Choose a reason for hiding this comment

Uh oh!

kination Oct 3, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AhyoungRyu Oct 9, 2016

Choose a reason for hiding this comment

Uh oh!

AhyoungRyu commented Sep 29, 2016

Uh oh!

AhyoungRyu commented Oct 7, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kination commented Oct 9, 2016

Uh oh!

AhyoungRyu commented Oct 9, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kination commented Oct 10, 2016

Uh oh!

kination commented Oct 25, 2016

Uh oh!

AhyoungRyu commented Oct 25, 2016

Uh oh!

kination commented Oct 25, 2016

Uh oh!

jongyoul commented Oct 31, 2016

Uh oh!

AhyoungRyu commented Oct 31, 2016

Uh oh!

AhyoungRyu commented Oct 31, 2016

Uh oh!

kination commented Nov 1, 2016

Uh oh!

AhyoungRyu commented Nov 1, 2016

Uh oh!

kination commented Nov 1, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

AhyoungRyu Sep 29, 2016 •

edited

Loading

kination Oct 3, 2016 •

edited

Loading

AhyoungRyu commented Oct 7, 2016 •

edited

Loading

AhyoungRyu commented Oct 9, 2016 •

edited

Loading