Skip to content

[MINOR] Hide "Currently there are no properties ~" msg & "edit", "restart" and "remove" btn in edit mode #1434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AhyoungRyu wants to merge 3 commits into from
Closed

[MINOR] Hide "Currently there are no properties ~" msg & "edit", "restart" and "remove" btn in edit mode #1434

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c6c937
Fix minor issues in interpreter setting edit mode
AhyoungRyu Sep 18, 2016
2e50f5d
Revert 'form'
AhyoungRyu Sep 19, 2016
4433f86
Make same width 'properties'&'dependencies' table
AhyoungRyu Sep 20, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions zeppelin-web/src/app/interpreter/interpreter.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ <h3 class="interpreter-title">{{setting.name}}
</small>

</h3>
<span style="float:right">
<span style="float:right" ng-show="!valueform.$visible" >
<button class="btn btn-default btn-xs"
ng-click="valueform.$show();
copyOriginInterpreterSettingProperties(setting.id)">
Expand All @@ -134,7 +134,7 @@ <h3 class="interpreter-title">{{setting.name}}
<span class="fa fa-refresh"></span> restart</button>
<button class="btn btn-default btn-xs"
ng-click="removeInterpreterSetting(setting.id)">
<span class="fa fa-remove"></span> remove</button>
<span class="fa fa-trash"></span> remove</button>
</span>
</div>
</div>
Expand Down Expand Up @@ -229,12 +229,12 @@ <h5>Option</h5>
</div>
</div>
</div>
</div>

<div ng-show="_.isEmpty(setting.properties) && _.isEmpty(setting.dependencies) || valueform.$hidden" class="col-md-12 gray40-message">
<div class="row interpreter" style="margin-top:20px !important">
<div ng-show="_.isEmpty(setting.properties) && _.isEmpty(setting.dependencies) && !valueform.$visible" class="col-md-12 gray40-message">
<em>Currently there are no properties and dependencies set for this interpreter</em>
</div>
</div>
<div class="row interpreter">
<div class="col-md-12" ng-show="!_.isEmpty(setting.properties) || valueform.$visible">
<h5>Properties</h5>
<table class="table table-striped">
Expand Down Expand Up @@ -285,8 +285,8 @@ <h5>Dependencies</h5>
<thead>
<tr>
<th style="width:40%">artifact</th>
<th>exclude</th>
<th ng-if="valueform.$visible">action</th>
<th style="width:40%">exclude</th>
<th style="width:20%" ng-if="valueform.$visible">action</th>
</tr>
</thead>
<tr ng-repeat="dep in setting.dependencies">
Expand Down