Skip to content

ZEPPELIN-1164: backport new Shiro realm to 0.6 branch#1344

Closed
bzz wants to merge 1 commit intoapache:branch-0.6from
bzz:branch-0.6-add-realm
Closed

ZEPPELIN-1164: backport new Shiro realm to 0.6 branch#1344
bzz wants to merge 1 commit intoapache:branch-0.6from
bzz:branch-0.6-add-realm

Conversation

@bzz
Copy link
Member

@bzz bzz commented Aug 19, 2016

Just a backport of #1173

Add a new Shiro Realm that lets users authenticate in Apache Zeppelin using their ZeppelinHub credentials.

`Feature`

* [x] - Create ZeppelinHub Realm that extends `AuthorizingRealm`.
* [x] - Update `shiro.ini` file and add ZeppelinHub configuration template.
* [x] - Add documentation

[Issue 1164](https://issues.apache.org/jira/browse/ZEPPELIN-1164)

 - Assuming that you already have an account [Zeppelinhub](https://www.zeppelinhub.com/register), edit `conf/shiro.ini` file and uncomment ZeppelinHub related configuration.
 - Start your Zeppelin
 - Login with your ZeppelinHub credentials.

* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? YES

Author: Anthony Corbacho <corbacho.anthony@gmail.com>

Closes apache#1173 from anthonycorbacho/feat/ZeppelinHubAuthentication and squashes the following commits:

63b06c6 [Anthony Corbacho] Fix rebase mistake in documentation
0f16344 [Anthony Corbacho] Fix typo in documentation
5a27871 [Anthony Corbacho] Add Documentation about ZeppelinHub Realm configuration
8347fa9 [Anthony Corbacho] Handle long line > 100 char
9bf96ba [Anthony Corbacho] Remove author tag...
64154d4 [Anthony Corbacho] Add more method comments.
c207b5e [Anthony Corbacho] Change check of token.getUsername() in doGetAuthenticationInfo by using StringUtils::isBlank instead of checking only null.
38683e1 [Anthony Corbacho] Add new setting in Shiri.ini to handle ZeppelinHub realm.
34a8e5e [Anthony Corbacho] Create new Apache Shiro Realm for ZeppelinHub
@bzz
Copy link
Member Author

bzz commented Aug 19, 2016

\cc @anthonycorbacho @Leemoonsoo @jongyoul for review

@anthonycorbacho
Copy link
Contributor

look good

@bzz
Copy link
Member Author

bzz commented Aug 19, 2016

Thanks @anthonycorbacho for prompt review!

Merging to branch-0.6 if there is no further discussion


On CI failure - somehow, both Spark 1.6 profiles fail similar:

Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.381 sec <<< FAILURE! - in org.apache.zeppelin.python.PythonInterpreterTest
testClose(org.apache.zeppelin.python.PythonInterpreterTest)  Time elapsed: 0.282 sec  <<< FAILURE!
java.lang.AssertionError: null
    at org.junit.Assert.fail(Assert.java:86)
    at org.junit.Assert.assertTrue(Assert.java:41)
    at org.junit.Assert.assertFalse(Assert.java:64)
    at org.junit.Assert.assertFalse(Assert.java:74)
    at org.apache.zeppelin.python.PythonInterpreterTest.testClose(PythonInterpreterTest.java:170)

asfgit pushed a commit that referenced this pull request Aug 19, 2016
Just a backport of #1173

Author: Anthony Corbacho <corbacho.anthony@gmail.com>

Closes #1344 from bzz/branch-0.6-add-realm and squashes the following commits:

fbf8615 [Anthony Corbacho] [ZEPPELIN-1164] ZeppelinHub Realm
@bzz bzz closed this Aug 19, 2016
@bzz bzz deleted the branch-0.6-add-realm branch August 19, 2016 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants