[ZEPPELIN-1164] ZeppelinHub Realm by anthonycorbacho · Pull Request #1173 · apache/zeppelin

anthonycorbacho · 2016-07-13T03:38:27Z

What is this PR for?

Add a new Shiro Realm that lets users authenticate in Apache Zeppelin using their ZeppelinHub credentials.

What type of PR is it?

Feature

Todos

- Create ZeppelinHub Realm that extends AuthorizingRealm.
- Update shiro.ini file and add ZeppelinHub configuration template.
- Add documentation

What is the Jira issue?

Issue 1164

How should this be tested?

Assuming that you already have an account Zeppelinhub, edit conf/shiro.ini file and uncomment ZeppelinHub related configuration.
Start your Zeppelin
Login with your ZeppelinHub credentials.

Screenshots (if appropriate)

Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? YES

khalidhuseynov · 2016-07-13T05:13:40Z

zeppelin-server/src/main/java/org/apache/zeppelin/realm/ZeppelinHubRealm.java

+  public ZeppelinHubRealm() {
+    super();
+    LOG.debug("Init ZeppelinhubRealm");
+    //TODO(anthonyc): think about more setting for this HTTP client. eg: if user use proxy etcetc... 


may need to address line length here, build fails with

ZeppelinHubRealm.java[68] (sizes) LineLength: Line is longer than 100 characters (found 101).

khalidhuseynov · 2016-07-21T03:05:43Z

build failed on zeppelin-web, which is not relevant. can we still re-trigger CI here?

anthonycorbacho · 2016-07-21T05:16:24Z

all green

khalidhuseynov · 2016-07-21T06:22:00Z

zeppelin-server/src/main/java/org/apache/zeppelin/realm/ZeppelinHubRealm.java

+    //                eg: if user uses proxy etcetc...
+    httpClient = new HttpClient();
+    gson = new Gson();
+    name = getClass().getName() + "_" + INSTANCE_COUNT.getAndIncrement();


one question, why we have INSTANCE_COUNT here and how name is used?

its a shiro specific needs for unique name.

khalidhuseynov · 2016-07-21T06:34:50Z

It looks good. one thing is that it should be documented as well so that others may implement their own authentication/authorization realms with their server. do you want to add it as a part of this PR or do it later?

anthonycorbacho · 2016-07-21T06:40:23Z

@khalidhuseynov i think it make sense to do it in this PR.

This Realm will let users login with they ZeppelinHub credentials.

…ng StringUtils::isBlank instead of checking only null.

anthonycorbacho · 2016-07-22T06:24:15Z

@khalidhuseynov @AhyoungRyu 5a27871 for documentation

AhyoungRyu · 2016-07-22T06:36:02Z

docs/security/shiroauthentication.md

 If you want to grant this permission to other users, you can change **roles[ ]** as you defined at `[users]` section.

-<br/>
-> **NOTE :** All of the above configurations are defined in the `conf/shiro.ini` file. This documentation is originally from [SECURITY-README.md](https://github.com/apache/zeppelin/blob/master/SECURITY-README.md).


Is there any particular reason to remove this sentence?

"All of the above configurations are defined in the conf/shiro.ini file."

IDK its after doing my rebase. should i bring it back?

i think it exists in master, so may need to bring it back. @AhyoungRyu as original author may check it

Just pushed the fix, @AhyoungRyu sorry about that.

@anthonycorbacho It's fine :) @khalidhuseynov thanks for your explanation!

khalidhuseynov · 2016-07-22T06:58:11Z

LGTM

AhyoungRyu · 2016-07-22T07:01:52Z

LGTM 👍

anthonycorbacho · 2016-07-22T07:03:19Z

merging if no more discussion

jongyoul · 2016-08-03T17:45:58Z

@anthonycorbacho I've tried to merge this PR into master and branch-0.6. I've succeeded to merge it into master but failed doing into branch-0.6. Is it OK?

anthonycorbacho · 2016-08-04T01:42:02Z

@jongyoul sure, no problemo
Thanks

### What is this PR for? Add a new Shiro Realm that lets users authenticate in Apache Zeppelin using their ZeppelinHub credentials. ### What type of PR is it? `Feature` ### Todos * [x] - Create ZeppelinHub Realm that extends `AuthorizingRealm`. * [x] - Update `shiro.ini` file and add ZeppelinHub configuration template. * [x] - Add documentation ### What is the Jira issue? [Issue 1164](https://issues.apache.org/jira/browse/ZEPPELIN-1164) ### How should this be tested? - Assuming that you already have an account [Zeppelinhub](https://www.zeppelinhub.com/register), edit `conf/shiro.ini` file and uncomment ZeppelinHub related configuration. - Start your Zeppelin - Login with your ZeppelinHub credentials. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? YES Author: Anthony Corbacho <corbacho.anthony@gmail.com> Closes apache#1173 from anthonycorbacho/feat/ZeppelinHubAuthentication and squashes the following commits: 63b06c6 [Anthony Corbacho] Fix rebase mistake in documentation 0f16344 [Anthony Corbacho] Fix typo in documentation 5a27871 [Anthony Corbacho] Add Documentation about ZeppelinHub Realm configuration 8347fa9 [Anthony Corbacho] Handle long line > 100 char 9bf96ba [Anthony Corbacho] Remove author tag... 64154d4 [Anthony Corbacho] Add more method comments. c207b5e [Anthony Corbacho] Change check of token.getUsername() in doGetAuthenticationInfo by using StringUtils::isBlank instead of checking only null. 38683e1 [Anthony Corbacho] Add new setting in Shiri.ini to handle ZeppelinHub realm. 34a8e5e [Anthony Corbacho] Create new Apache Shiro Realm for ZeppelinHub

Add a new Shiro Realm that lets users authenticate in Apache Zeppelin using their ZeppelinHub credentials. `Feature` * [x] - Create ZeppelinHub Realm that extends `AuthorizingRealm`. * [x] - Update `shiro.ini` file and add ZeppelinHub configuration template. * [x] - Add documentation [Issue 1164](https://issues.apache.org/jira/browse/ZEPPELIN-1164) - Assuming that you already have an account [Zeppelinhub](https://www.zeppelinhub.com/register), edit `conf/shiro.ini` file and uncomment ZeppelinHub related configuration. - Start your Zeppelin - Login with your ZeppelinHub credentials. * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? YES Author: Anthony Corbacho <corbacho.anthony@gmail.com> Closes apache#1173 from anthonycorbacho/feat/ZeppelinHubAuthentication and squashes the following commits: 63b06c6 [Anthony Corbacho] Fix rebase mistake in documentation 0f16344 [Anthony Corbacho] Fix typo in documentation 5a27871 [Anthony Corbacho] Add Documentation about ZeppelinHub Realm configuration 8347fa9 [Anthony Corbacho] Handle long line > 100 char 9bf96ba [Anthony Corbacho] Remove author tag... 64154d4 [Anthony Corbacho] Add more method comments. c207b5e [Anthony Corbacho] Change check of token.getUsername() in doGetAuthenticationInfo by using StringUtils::isBlank instead of checking only null. 38683e1 [Anthony Corbacho] Add new setting in Shiri.ini to handle ZeppelinHub realm. 34a8e5e [Anthony Corbacho] Create new Apache Shiro Realm for ZeppelinHub

Just a backport of #1173 Author: Anthony Corbacho <corbacho.anthony@gmail.com> Closes #1344 from bzz/branch-0.6-add-realm and squashes the following commits: fbf8615 [Anthony Corbacho] [ZEPPELIN-1164] ZeppelinHub Realm

Add a new Shiro Realm that lets users authenticate in Apache Zeppelin using their ZeppelinHub credentials. `Feature` * [x] - Create ZeppelinHub Realm that extends `AuthorizingRealm`. * [x] - Update `shiro.ini` file and add ZeppelinHub configuration template. * [x] - Add documentation [Issue 1164](https://issues.apache.org/jira/browse/ZEPPELIN-1164) - Assuming that you already have an account [Zeppelinhub](https://www.zeppelinhub.com/register), edit `conf/shiro.ini` file and uncomment ZeppelinHub related configuration. - Start your Zeppelin - Login with your ZeppelinHub credentials. * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? YES Author: Anthony Corbacho <corbacho.anthony@gmail.com> Closes #1173 from anthonycorbacho/feat/ZeppelinHubAuthentication and squashes the following commits: 63b06c6 [Anthony Corbacho] Fix rebase mistake in documentation 0f16344 [Anthony Corbacho] Fix typo in documentation 5a27871 [Anthony Corbacho] Add Documentation about ZeppelinHub Realm configuration 8347fa9 [Anthony Corbacho] Handle long line > 100 char 9bf96ba [Anthony Corbacho] Remove author tag... 64154d4 [Anthony Corbacho] Add more method comments. c207b5e [Anthony Corbacho] Change check of token.getUsername() in doGetAuthenticationInfo by using StringUtils::isBlank instead of checking only null. 38683e1 [Anthony Corbacho] Add new setting in Shiri.ini to handle ZeppelinHub realm. 34a8e5e [Anthony Corbacho] Create new Apache Shiro Realm for ZeppelinHub (cherry picked from commit e6f51e7) Signed-off-by: Mina Lee <minalee@apache.org> Conflicts: docs/security/shiroauthentication.md

anthonycorbacho changed the title ~~ZeppelinHub Realm~~ [ZEPPELIN-1164] ZeppelinHub Realm Jul 13, 2016

khalidhuseynov reviewed Jul 13, 2016
View reviewed changes

anthonycorbacho closed this Jul 21, 2016

anthonycorbacho reopened this Jul 21, 2016

khalidhuseynov reviewed Jul 21, 2016
View reviewed changes

anthonycorbacho added 7 commits July 22, 2016 15:19

Create new Apache Shiro Realm for ZeppelinHub

34a8e5e

This Realm will let users login with they ZeppelinHub credentials.

Add new setting in Shiri.ini to handle ZeppelinHub realm.

38683e1

Change check of token.getUsername() in doGetAuthenticationInfo by usi…

c207b5e

…ng StringUtils::isBlank instead of checking only null.

Add more method comments.

64154d4

Remove author tag...

9bf96ba

Handle long line > 100 char

8347fa9

Add Documentation about ZeppelinHub Realm configuration

5a27871

AhyoungRyu reviewed Jul 22, 2016
View reviewed changes

anthonycorbacho added 2 commits July 22, 2016 15:49

Fix typo in documentation

0f16344

Fix rebase mistake in documentation

63b06c6

asfgit closed this in e6f51e7 Aug 3, 2016

anthonycorbacho deleted the feat/ZeppelinHubAuthentication branch August 4, 2016 01:42

bzz mentioned this pull request Aug 19, 2016

ZEPPELIN-1164: backport new Shiro realm to 0.6 branch #1344

Closed

Conversation

anthonycorbacho commented Jul 13, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What is this PR for?

What type of PR is it?

Todos

What is the Jira issue?

How should this be tested?

Screenshots (if appropriate)

Questions:

Uh oh!

khalidhuseynov Jul 13, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

khalidhuseynov commented Jul 21, 2016

Uh oh!

anthonycorbacho commented Jul 21, 2016

Uh oh!

khalidhuseynov Jul 21, 2016

Choose a reason for hiding this comment

Uh oh!

anthonycorbacho Jul 21, 2016

Choose a reason for hiding this comment

Uh oh!

khalidhuseynov commented Jul 21, 2016

Uh oh!

anthonycorbacho commented Jul 21, 2016

Uh oh!

anthonycorbacho commented Jul 22, 2016

Uh oh!

AhyoungRyu Jul 22, 2016

Choose a reason for hiding this comment

Uh oh!

anthonycorbacho Jul 22, 2016

Choose a reason for hiding this comment

Uh oh!

khalidhuseynov Jul 22, 2016

Choose a reason for hiding this comment

Uh oh!

anthonycorbacho Jul 22, 2016

Choose a reason for hiding this comment

Uh oh!

AhyoungRyu Jul 22, 2016

Choose a reason for hiding this comment

Uh oh!

khalidhuseynov commented Jul 22, 2016

Uh oh!

AhyoungRyu commented Jul 22, 2016

Uh oh!

anthonycorbacho commented Jul 22, 2016

Uh oh!

jongyoul commented Aug 3, 2016

Uh oh!

anthonycorbacho commented Aug 4, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

anthonycorbacho commented Jul 13, 2016 •

edited

Loading

khalidhuseynov Jul 13, 2016 •

edited

Loading