getPort should not have curly bracket in its body #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks! Looks good to me. |
Member
|
Thank you for bringing it in again! |
Contributor
|
Hi, @echarles Can you explain to me exactly what is the relation between the getPort function and the AppScriptServlet? And how they work together? I'm currently planning on rebasing the #56 PR to master, and in that commit: corneadoug@bc76301 I made changes to move those functions (getPort, getWebsocketProtocol, getRestApiBase) to their own service, instead of having them inside of app.js |
Member
|
Because of AppScriptServlet replace |
asfgit
pushed a commit
that referenced
this pull request
Jul 2, 2015
After so much time in the Wild Wild West of Internet, It's Time for the Spring Cleaning of Zeppelin-web. This PR will be taking care of cleaning the code, architecture, cutting code into smaller pieces etc... * [x] - Change Code Folder Structure to a Folder Tree Style * [x] - Change original code and compiled code folder names * [x] - Update Contributing README.md to explain most of changes * [x] - Organize well the components and app folders We will do a first merge and handle this part in a different PR: * [ ] - Replace as much code as possible by their lodash.js counterpart * [ ] - Cut the code into more smaller components (who said paragraph.js?) * [ ] - Move Jquery code out of the controllers (by directive when possible or to somewhere else) Needs to make sure that: * [x] - #127 is handled Author: Damien Corneau <[email protected]> Author: CORNEAU Damien <[email protected]> Closes #56 from corneadoug/improvement/SpringCleaning and squashes the following commits: 453af1a [Damien Corneau] Merge Master and Fix ports 678c0fa [Damien Corneau] Fix RAT excluded and add Apache licenses in zeppelin-web 0addb80 [Damien Corneau] Change AppScriptServlet configuration ef764fc [Damien Corneau] Improve uglifyjs options 15cc7b1 [CORNEAU Damien] Fix README e3ca174 [CORNEAU Damien] Small fix in doc 775f3ca [Damien Corneau] Remove unused ngdoc comments 25a3a63 [Damien Corneau] Fix Interpreter Create form bdde389 [Damien Corneau] Set loonknfeel to default for everypage, and change only if looknfeel is different bdf3a8e [Damien Corneau] Include lodash + Interpreter Web refactoring Part1: reducing code 931067a [Damien Corneau] Align form label to form input + improve form disable opacity 75d12c3 [Damien Corneau] Fix CSS of paragraph forms e3f3016 [Damien Corneau] Fix ZEPPELIN-102 a6ec901 [Damien Corneau] Fix ZEPPELIN-103 7eccca8 [Damien Corneau] Fix navbar selected menu + small code improvement a1fe1c1 [Damien Corneau] Refactoring of Websocket a36adf9 [Damien Corneau] Move all websocket calls to a service b21cc69 [Damien Corneau] Refactor Navbar controller to controller pattern + data factory 5a40c4c [Damien Corneau] Separate navbar to its own html file 2dac138 [Damien Corneau] Move directives to solo directory 9201360 [Damien Corneau] Fix project after git clean 9b249ea [Damien Corneau] Clean JSHint errors except for already defined and configuration functions related errors ef6baa0 [CORNEAU Damien] Update Zeppelin-web CONTRIBUTING.md 411df6a [Damien Corneau] Create Zeppelin-web CONTRIBUTING.md d3c22cf [CORNEAU Damien] Update Zeppelin-web README.md 48eed51 [Damien Corneau] Move the font css 3e28c3c [Damien Corneau] Change Zeppelin-web code and compiled code folders 0ee04a2 [Damien Corneau] Fix Grunt watch 15b502c [Damien Corneau] Change Zeppelin Folder Structure and its GruntFile 9f9059e [Damien Corneau] Add spark dependency reduced pom to gitignore
Leemoonsoo
pushed a commit
to Leemoonsoo/zeppelin
that referenced
this pull request
Sep 17, 2015
This patch simply remove the usage of curly bracket in the body of the getPort method of the app.js. This is needed so the AppScriptServlet can do its correctly in case of developement in both client and server sides. Author: Eric Charles <[email protected]> Closes apache#127 from echarles/app-js-server-mode and squashes the following commits: dfaba55 [Eric Charles] getPort should not have curly bracket in its body (cherry picked from commit b15b201) Signed-off-by: Lee moon soo <[email protected]>
Leemoonsoo
pushed a commit
to Leemoonsoo/zeppelin
that referenced
this pull request
Sep 17, 2015
After so much time in the Wild Wild West of Internet, It's Time for the Spring Cleaning of Zeppelin-web. This PR will be taking care of cleaning the code, architecture, cutting code into smaller pieces etc... * [x] - Change Code Folder Structure to a Folder Tree Style * [x] - Change original code and compiled code folder names * [x] - Update Contributing README.md to explain most of changes * [x] - Organize well the components and app folders We will do a first merge and handle this part in a different PR: * [ ] - Replace as much code as possible by their lodash.js counterpart * [ ] - Cut the code into more smaller components (who said paragraph.js?) * [ ] - Move Jquery code out of the controllers (by directive when possible or to somewhere else) Needs to make sure that: * [x] - apache#127 is handled Author: Damien Corneau <[email protected]> Author: CORNEAU Damien <[email protected]> Closes apache#56 from corneadoug/improvement/SpringCleaning and squashes the following commits: 453af1a [Damien Corneau] Merge Master and Fix ports 678c0fa [Damien Corneau] Fix RAT excluded and add Apache licenses in zeppelin-web 0addb80 [Damien Corneau] Change AppScriptServlet configuration ef764fc [Damien Corneau] Improve uglifyjs options 15cc7b1 [CORNEAU Damien] Fix README e3ca174 [CORNEAU Damien] Small fix in doc 775f3ca [Damien Corneau] Remove unused ngdoc comments 25a3a63 [Damien Corneau] Fix Interpreter Create form bdde389 [Damien Corneau] Set loonknfeel to default for everypage, and change only if looknfeel is different bdf3a8e [Damien Corneau] Include lodash + Interpreter Web refactoring Part1: reducing code 931067a [Damien Corneau] Align form label to form input + improve form disable opacity 75d12c3 [Damien Corneau] Fix CSS of paragraph forms e3f3016 [Damien Corneau] Fix ZEPPELIN-102 a6ec901 [Damien Corneau] Fix ZEPPELIN-103 7eccca8 [Damien Corneau] Fix navbar selected menu + small code improvement a1fe1c1 [Damien Corneau] Refactoring of Websocket a36adf9 [Damien Corneau] Move all websocket calls to a service b21cc69 [Damien Corneau] Refactor Navbar controller to controller pattern + data factory 5a40c4c [Damien Corneau] Separate navbar to its own html file 2dac138 [Damien Corneau] Move directives to solo directory 9201360 [Damien Corneau] Fix project after git clean 9b249ea [Damien Corneau] Clean JSHint errors except for already defined and configuration functions related errors ef6baa0 [CORNEAU Damien] Update Zeppelin-web CONTRIBUTING.md 411df6a [Damien Corneau] Create Zeppelin-web CONTRIBUTING.md d3c22cf [CORNEAU Damien] Update Zeppelin-web README.md 48eed51 [Damien Corneau] Move the font css 3e28c3c [Damien Corneau] Change Zeppelin-web code and compiled code folders 0ee04a2 [Damien Corneau] Fix Grunt watch 15b502c [Damien Corneau] Change Zeppelin Folder Structure and its GruntFile 9f9059e [Damien Corneau] Add spark dependency reduced pom to gitignore (cherry picked from commit 8c7424a) Signed-off-by: Lee moon soo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch simply remove the usage of curly bracket in the body of the getPort method of the app.js.
This is needed so the AppScriptServlet can do its correctly in case of developement in both client and server sides.