Port is now retrieved by AppScriptServlet

[echarles]

The AppScriptServlet changes the content of app.js on the fly.
When I run vanilla zeppelin, I receive a blank page with a js error: SyntaxError: syntax error function getPort(){return 8081} else if (location.protocol === 'https:' && (port...
The changes simply removes the unneeded js code, leaving the server to the job for the port definition.

[anthonycorbacho]

what if I use grunt serve? will I be able to work on Zeppelin?

[Leemoonsoo]

@echarles Thanks for raising issue.
The code was for zeppelin-web development mode.
(cd zeppelin-web; grunt serve runs zeppelin-web dev mode on port 9000)

While dev mode gives big value (code changes reflected on the fly, does not need to rebuild project every single change) in zeppelin-web development, I think it's worth to keep the feature. Is it possible to solve your problem with keeping dev mode support?

[echarles]

@Leemoonsoo just pushed a change which keeps dev mode support.
Just curious, grunt serve is useful to test some changes which don't need server features, so quite limited. Or do you have a way to use grunt serve to also test serve-side functions?

[anthonycorbacho]

we use grunt serve for front end dev.
basically what I do is start a Zeppelin daemon and then start a grunt serve.

this is really usefull because with the grunt serve we got live reload, a
watcher, jshint checking change and we dont need to rebuild the webapp
every time we change something on the front. this is time saving and allow
you to quickly implement front feature.
On Feb 12, 2015 4:32 AM, "Eric Charles" [email protected] wrote:

@Leemoonsoo https://github.com/Leemoonsoo just pushed a change which
keeps dev mode support.
Just curious, grunt serve is useful to test some changes which don't need
server features, so quite limited. Or do you have a way to use grunt serve
to also test serve-side functions?

—
Reply to this email directly or view it on GitHub
#335 (comment).

[Leemoonsoo]

@echarles Like @anthonycorbacho said, grunt serve only runs front-end. but zeppelin daemon can un separately and then grunt serve connects Zeppelin-daemon.

This PR Looks good to me! Thanks for contribution!

[swkimme]

LGTM to me, but please hold merging until #321 is merged.

[Leemoonsoo]

@echarles Zeppelin recently has moved to Apache and this repository will not accept update anymore. Could you recreate your pull-request to https://github.com/apache/incubator-zeppelin?

[echarles]

@Leemoonsoo See apache/zeppelin#127