[ZEPPELIN-1189] Get note revision websocket api#1192
[ZEPPELIN-1189] Get note revision websocket api#1192khalidhuseynov wants to merge 8 commits intoapache:masterfrom
Conversation
khalidhuseynov
changed the title
|
Looks like CI fails, could you please followup on the reason? One more question - it looks like this PR not only add websocket API but change backend API and modify every NotebookRrpo implementation. Is there a way to avoid such changes in a single PR? Or is there a strong reason for breaking API here? |
…ject to String revId" This reverts commit baaa704.
instead of revisionId string
|
@bzz fixed the issue with CI. |
|
Sounds great, thank you for taking care! CI is still failing though :\ Please feel free to followup the failure here and I will be happy to help, if needed! |
|
@bzz addressed the changes and CI is green |
|
Looks great to me! Thank you for taking care. Megin if there is no further discussion |
### What is this PR for? Adds websocket api for getting note revision. ### What type of PR is it? Improvement | Feature ### Todos * [x] - add backend websocket handle * [x] - add frontend call ### What is the Jira issue? [apache#1189](https://issues.apache.org/jira/browse/ZEPPELIN-1189) ### How should this be tested? green CI (can be tested once frontend implemented) ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Khalid Huseynov <khalidhnv@nflabs.com> Author: Khalid Huseynov <khalidhuseynov@Khalids-MacBook-Pro.local> Author: Khalid Huseynov <khalidhnv@gmail.com> Closes apache#1192 from khalidhuseynov/versioning/get-note-revision-api and squashes the following commits: f1ab994 [Khalid Huseynov] Merge branch 'master' into versioning/get-note-revision-api 683b481 [Khalid Huseynov] receive Revision object from frontend aa0a7d6 [Khalid Huseynov] Revert "change NotebookRepo api to get note revision from Revision object to String revId" ce097ed [Khalid Huseynov] add throws to notebook getRevisionNote baaa704 [Khalid Huseynov] change NotebookRepo api to get note revision from Revision object to String revId d9751c3 [Khalid Huseynov] add backend ws api to get note revision 3783fc9 [Khalid Huseynov] receive ws NOTE_REVISION msg 79f8ac9 [Khalid Huseynov] add getNoteRevision to front
2 participants
What is this PR for?
Adds websocket api for getting note revision.
What type of PR is it?
Improvement | Feature
Todos
What is the Jira issue?
#1189
How should this be tested?
green CI (can be tested once frontend implemented)
Screenshots (if appropriate)
Questions: