ZEPPELIN-1185. ZEPPELIN_INTP_JAVA_OPTS should not use ZEPPELIN_JAVA_OPTS by zjffdu · Pull Request #1189 · apache/zeppelin

zjffdu · 2016-07-15T06:23:07Z

What is this PR for?

Don't use ZEPPELIN_JAVA_OPTS as the default value of ZEPPELIN_INTP_JAVA_OPTS

What type of PR is it?

Improvement

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-1185

How should this be tested?

Tested manually. By exporting the following variable, I can debug zeppelin server correctly and remote interpreter process can ran successfully. (Before this PR, the remote interpreter process will fail to launch because it would also listen the same debug port)

export ZEPPELIN_JAVA_OPTS="-agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=5005"

Leemoonsoo · 2016-07-16T20:24:29Z

Thanks for contribution!

ZEPPELIN_JAVA_OPTS used to set JVM options both ZeppelinServer and InterpreterProcess.
Later ZEPPELIN_INTP_JAVA_OPTS has been introduced. To keep compatibility with previous configuration, ZEPPELIN_INTP_JAVA_OPTS designed to overrides ZEPPELIN_JAVA_OPTS for InterpreterProcess.
So previous version of conf/zeppelin-env.sh can work without modification.
That's why InterpreterProcess looks like implicitly uses ZEPPELIN_JAVA_OPTS.

I don't have any preference of either keeping current behavior or change it.

But if you'd like to change, I think ZEPPELIN_INTP_MEM also need to be changed, to make configuration consistent.

Also, this change makes conf/zeppelin-env.sh incompatible to previous version. So i think it's great idea that guide user how ZEPPELIN_JAVA_OPTS and ZEPPELIN_INTP_JAVA_OPTS are changed through https://github.com/apache/zeppelin/blob/master/docs/install/upgrade.md.

### What is this PR for? Adds websocket api for getting note revision. ### What type of PR is it? Improvement | Feature ### Todos * [x] - add backend websocket handle * [x] - add frontend call ### What is the Jira issue? [#1189](https://issues.apache.org/jira/browse/ZEPPELIN-1189) ### How should this be tested? green CI (can be tested once frontend implemented) ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Khalid Huseynov <[email protected]> Author: Khalid Huseynov <[email protected]> Author: Khalid Huseynov <[email protected]> Closes #1192 from khalidhuseynov/versioning/get-note-revision-api and squashes the following commits: f1ab994 [Khalid Huseynov] Merge branch 'master' into versioning/get-note-revision-api 683b481 [Khalid Huseynov] receive Revision object from frontend aa0a7d6 [Khalid Huseynov] Revert "change NotebookRepo api to get note revision from Revision object to String revId" ce097ed [Khalid Huseynov] add throws to notebook getRevisionNote baaa704 [Khalid Huseynov] change NotebookRepo api to get note revision from Revision object to String revId d9751c3 [Khalid Huseynov] add backend ws api to get note revision 3783fc9 [Khalid Huseynov] receive ws NOTE_REVISION msg 79f8ac9 [Khalid Huseynov] add getNoteRevision to front

zjffdu · 2016-07-26T01:18:42Z

@Leemoonsoo I pushed another commit to add migration section in upgrade.md, please help review. Thanks.

AhyoungRyu · 2016-07-26T01:39:52Z

docs/install/upgrade.md

-   ```
+   ```
+
+# Migration Guide


Could you change # -> ## ? Since # is used only for the docs title in many other pages and # won't be rendered under TOC as well.

zjffdu · 2016-07-26T03:08:24Z

Thanks @AhyoungRyu , I have updated the doc.

zjffdu · 2016-07-26T03:09:14Z

BTW, I will do the windows related change (common.cmd, zeppelin-env.cmd.template) after we make consensus on this approach.

…PTS as default value

zjffdu · 2016-08-04T10:32:51Z

\cc @Leemoonsoo Ready for review.

Leemoonsoo · 2016-08-07T16:30:46Z

Change looks good.
Could you trigger CI once again and see if it becomes green?

### What is this PR for? Adds websocket api for getting note revision. ### What type of PR is it? Improvement | Feature ### Todos * [x] - add backend websocket handle * [x] - add frontend call ### What is the Jira issue? [apache#1189](https://issues.apache.org/jira/browse/ZEPPELIN-1189) ### How should this be tested? green CI (can be tested once frontend implemented) ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Khalid Huseynov <[email protected]> Author: Khalid Huseynov <[email protected]> Author: Khalid Huseynov <[email protected]> Closes apache#1192 from khalidhuseynov/versioning/get-note-revision-api and squashes the following commits: f1ab994 [Khalid Huseynov] Merge branch 'master' into versioning/get-note-revision-api 683b481 [Khalid Huseynov] receive Revision object from frontend aa0a7d6 [Khalid Huseynov] Revert "change NotebookRepo api to get note revision from Revision object to String revId" ce097ed [Khalid Huseynov] add throws to notebook getRevisionNote baaa704 [Khalid Huseynov] change NotebookRepo api to get note revision from Revision object to String revId d9751c3 [Khalid Huseynov] add backend ws api to get note revision 3783fc9 [Khalid Huseynov] receive ws NOTE_REVISION msg 79f8ac9 [Khalid Huseynov] add getNoteRevision to front

zjffdu · 2016-08-17T01:17:59Z

ping @Leemoonsoo in case you miss it.

bzz · 2016-08-17T05:50:05Z

I guess @khalidhuseynov did not mean to refer this PR, but just used short-cut to name the JIRA issue.

Leemoonsoo · 2016-08-24T11:31:22Z

Thanks @zjffdu.
LGTM and merge if there's no more discussion.

prabhjyotsingh · 2016-08-31T14:08:09Z

I'll merge this in sometime soon.

### What is this PR for? Don't use ZEPPELIN_JAVA_OPTS as the default value of ZEPPELIN_INTP_JAVA_OPTS ### What type of PR is it? Improvement ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1185 ### How should this be tested? Tested manually. By exporting the following variable, I can debug zeppelin server correctly and remote interpreter process can ran successfully. (Before this PR, the remote interpreter process will fail to launch because it would also listen the same debug port) ``` export ZEPPELIN_JAVA_OPTS="-agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=5005" ``` Author: Jeff Zhang <[email protected]> Closes #1189 from zjffdu/ZEPPELIN-1185 and squashes the following commits: 9e48ad7 [Jeff Zhang] change for windows 3ff5561 [Jeff Zhang] update doc format e82d889 [Jeff Zhang] add migration doc ef5a360 [Jeff Zhang] ZEPPELIN-1185. ZEPPELIN_INTP_JAVA_OPTS should not use ZEPPELIN_JAVA_OPTS as default value (cherry picked from commit 93e3762) Signed-off-by: Prabhjyot Singh <[email protected]>

zjffdu force-pushed the ZEPPELIN-1185 branch from a54d843 to 0e9b070 Compare July 26, 2016 01:17

AhyoungRyu reviewed Jul 26, 2016
View reviewed changes

zjffdu added 4 commits August 4, 2016 18:13

ZEPPELIN-1185. ZEPPELIN_INTP_JAVA_OPTS should not use ZEPPELIN_JAVA_O…

ef5a360

…PTS as default value

add migration doc

e82d889

update doc format

3ff5561

change for windows

9e48ad7

zjffdu force-pushed the ZEPPELIN-1185 branch from ba6ff4c to 9e48ad7 Compare August 4, 2016 10:23

zjffdu closed this Aug 7, 2016

zjffdu reopened this Aug 7, 2016

zjffdu closed this Aug 8, 2016

zjffdu reopened this Aug 8, 2016

zjffdu closed this Aug 8, 2016

zjffdu reopened this Aug 8, 2016

asfgit closed this in 93e3762 Sep 1, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ZEPPELIN-1185. ZEPPELIN_INTP_JAVA_OPTS should not use ZEPPELIN_JAVA_OPTS#1189

ZEPPELIN-1185. ZEPPELIN_INTP_JAVA_OPTS should not use ZEPPELIN_JAVA_OPTS#1189
zjffdu wants to merge 4 commits intoapache:masterfrom
zjffdu:ZEPPELIN-1185

zjffdu commented Jul 15, 2016 •

edited

Loading

Uh oh!

Leemoonsoo commented Jul 16, 2016

Uh oh!

zjffdu commented Jul 26, 2016

Uh oh!

AhyoungRyu Jul 26, 2016 •

edited

Loading

Uh oh!

zjffdu commented Jul 26, 2016

Uh oh!

zjffdu commented Jul 26, 2016 •

edited

Loading

Uh oh!

zjffdu commented Aug 4, 2016

Uh oh!

Leemoonsoo commented Aug 7, 2016

Uh oh!

zjffdu commented Aug 17, 2016

Uh oh!

bzz commented Aug 17, 2016

Uh oh!

Leemoonsoo commented Aug 24, 2016

Uh oh!

prabhjyotsingh commented Aug 31, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

zjffdu commented Jul 15, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What is this PR for?

What type of PR is it?

What is the Jira issue?

How should this be tested?

Uh oh!

Leemoonsoo commented Jul 16, 2016

Uh oh!

zjffdu commented Jul 26, 2016

Uh oh!

AhyoungRyu Jul 26, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zjffdu commented Jul 26, 2016

Uh oh!

zjffdu commented Jul 26, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zjffdu commented Aug 4, 2016

Uh oh!

Leemoonsoo commented Aug 7, 2016

Uh oh!

zjffdu commented Aug 17, 2016

Uh oh!

bzz commented Aug 17, 2016

Uh oh!

Leemoonsoo commented Aug 24, 2016

Uh oh!

prabhjyotsingh commented Aug 31, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

zjffdu commented Jul 15, 2016 •

edited

Loading

AhyoungRyu Jul 26, 2016 •

edited

Loading

zjffdu commented Jul 26, 2016 •

edited

Loading