Skip to content

[HOTFIX] NPE when there's no properties field in interpreter-setting.json #1128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jongyoul wants to merge 1 commit into from
Closed

[HOTFIX] NPE when there's no properties field in interpreter-setting.json #1128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,8 +212,11 @@ public boolean accept(Path entry) throws IOException {
if (null != infos) {
Properties p = new Properties();
for (RegisteredInterpreter info : infos) {
for (String key : info.getProperties().keySet()) {
p.put(key, info.getProperties().get(key).getValue());
Map<String, InterpreterProperty> interpreterProperties = info.getProperties();
if (null != interpreterProperties) {
for (String key : info.getProperties().keySet()) {
p.put(key, info.getProperties().get(key).getValue());
}
}
}
add(groupName, groupName, new LinkedList<Dependency>(), defaultOption, p);
Expand All @@ -224,8 +227,11 @@ public boolean accept(Path entry) throws IOException {
List<RegisteredInterpreter> infos = groupClassNameMap.get(groupName);
Properties p = new Properties();
for (RegisteredInterpreter info : infos) {
for (String key : info.getProperties().keySet()) {
p.put(key, info.getProperties().get(key).getValue());
Map<String, InterpreterProperty> interpreterProperties = info.getProperties();
if (null != interpreterProperties) {
for (String key : info.getProperties().keySet()) {
p.put(key, info.getProperties().get(key).getValue());
}
}
}
add(groupName, groupName, new LinkedList<Dependency>(), defaultOption, p);
Expand Down