[HOTFIX] NPE when there's no properties field in interpreter-setting.json #1128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM |
Member
|
Looks good to me, let's merge asap as HOTFIX |
jongyoul
force-pushed
the
hotfix/interpreter-properties-is-null
branch
from
0b89b3a to
1dcf562
Compare
Contributor
|
Good catch, agreed with @bzz, let's merge asap. |
PhilippGrulich
pushed a commit
to SWC-SENSE/zeppelin
that referenced
this pull request
Aug 8, 2016
…json ### What is this PR for? Fixing NPE while initializing interpreters from interpreter-setting.json ### What type of PR is it? [Bug Fix | Hot Fix] ### Todos * [x] - Fix NPE ### What is the Jira issue? N/A ### How should this be tested? 1. delete `properties` in one of `interpreter-setting.json` 1. Build and run 1. Got error 1. Apply this PR 1. Build and run 1. Run it successfully ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jongyoul Lee <[email protected]> Closes apache#1128 from jongyoul/hotfix/interpreter-properties-is-null and squashes the following commits: 1dcf562 [Jongyoul Lee] Fixed NPE when there's no properties field in interpreter-setting.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Fixing NPE while initializing interpreters from interpreter-setting.json
What type of PR is it?
[Bug Fix | Hot Fix]
Todos
What is the Jira issue?
N/A
How should this be tested?
propertiesin one ofinterpreter-setting.jsonScreenshots (if appropriate)
Questions: