Skip to content

Conversation

@prabhjyotsingh
Copy link
Contributor

@prabhjyotsingh prabhjyotsingh commented Jun 30, 2016

What is this PR for?

LivySparkSQLInterpreter should work in FIFO with LivySparkInterpreter just like SparkSqlInterpreter works with SparkInterpreter

What type of PR is it?

[Hot Fix]

Todos

  • - LivySparkSQLInterpreter should work in FIFO just like SparkSqlInterpreter
  • - add in property file zeppelin.livy.concurrentSQL

What is the Jira issue?

How should this be tested?

In a notebook create 2 paragraph make content of first as

%livy
Thread.sleep(10000)

and other as

%livy.sql
show tables

The second paragraph should not get executed before first.

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? n/a
  • Is there breaking changes for older versions? n/a
  • Does this needs documentation? n/a

@prabhjyotsingh
Copy link
Contributor Author

@bzz CI still fails #1094

-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running org.apache.zeppelin.python.PythonInterpreterTest
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in [jar:file:/home/travis/build/apache/zeppelin/zeppelin-interpreter/target/zeppelin-interpreter-0.6.0-SNAPSHOT.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/home/travis/build/apache/zeppelin/zeppelin-interpreter/target/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/home/travis/.m2/repository/org/slf4j/slf4j-log4j12/1.7.10/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
log4j:WARN No appenders could be found for logger (org.apache.zeppelin.interpreter.Interpreter).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info.
Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.424 sec <<< FAILURE! - in org.apache.zeppelin.python.PythonInterpreterTest
testClose(org.apache.zeppelin.python.PythonInterpreterTest)  Time elapsed: 0.319 sec  <<< FAILURE!
java.lang.AssertionError: null
    at org.junit.Assert.fail(Assert.java:86)
    at org.junit.Assert.assertTrue(Assert.java:41)
    at org.junit.Assert.assertFalse(Assert.java:64)
    at org.junit.Assert.assertFalse(Assert.java:74)
    at org.apache.zeppelin.python.PythonInterpreterTest.testClose(PythonInterpreterTest.java:141)


Results :

Failed tests: 
  PythonInterpreterTest.testClose:141 null

https://api.travis-ci.org/jobs/141302291/log.txt?deansi=true

@prabhjyotsingh prabhjyotsingh changed the title [Zeppelin-1090] LivySparkSQLInterpreter doesn't work in FIFO. [Zeppelin-1090][Hot Fix] LivySparkSQLInterpreter doesn't work in FIFO. Jun 30, 2016
@r-kamath
Copy link
Member

Thanks for the fix. LGTM

@prabhjyotsingh
Copy link
Contributor Author

Merging this if no more discussion.

@asfgit asfgit closed this in d20dbce Jul 2, 2016
asfgit pushed a commit that referenced this pull request Jul 2, 2016
LivySparkSQLInterpreter should work in FIFO with LivySparkInterpreter just like SparkSqlInterpreter works with SparkInterpreter

[Hot Fix]

* [x] - LivySparkSQLInterpreter should work in FIFO just like SparkSqlInterpreter
* [x] - add in property file zeppelin.livy.concurrentSQL

* [Zeppelin-1090](https://issues.apache.org/jira/browse/ZEPPELIN-1090)

In a notebook create 2 paragraph make content of first as

```
%livy
Thread.sleep(10000)
```

and other as

```
%livy.sql
show tables
```

The second paragraph should not get executed before first.

* Does the licenses files need update? n/a
* Is there breaking changes for older versions? n/a
* Does this needs documentation? n/a

Author: Prabhjyot Singh <[email protected]>

Closes #1109 from prabhjyotsingh/ZEPPELIN-1090 and squashes the following commits:

a2f863e [Prabhjyot Singh] check for both dead and error cases
fe2ec72 [Prabhjyot Singh] LivySparkSQLInterpreter should work in FIFO just like SparkSqlInterpreter
2f1c64c [Prabhjyot Singh] add in property file zeppelin.livy.concurrentSQL
PhilippGrulich pushed a commit to SWC-SENSE/zeppelin that referenced this pull request Aug 8, 2016
### What is this PR for?
LivySparkSQLInterpreter should work in FIFO with LivySparkInterpreter just like SparkSqlInterpreter works with SparkInterpreter

### What type of PR is it?
[Hot Fix]

### Todos
* [x] - LivySparkSQLInterpreter should work in FIFO just like SparkSqlInterpreter
* [x] - add in property file zeppelin.livy.concurrentSQL

### What is the Jira issue?
* [Zeppelin-1090](https://issues.apache.org/jira/browse/ZEPPELIN-1090)

### How should this be tested?
In a notebook create 2 paragraph make content of first as

```
%livy
Thread.sleep(10000)
```

and other as

```
%livy.sql
show tables
```

The second paragraph should not get executed before first.

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? n/a
* Is there breaking changes for older versions? n/a
* Does this needs documentation? n/a

Author: Prabhjyot Singh <[email protected]>

Closes apache#1109 from prabhjyotsingh/ZEPPELIN-1090 and squashes the following commits:

a2f863e [Prabhjyot Singh] check for both dead and error cases
fe2ec72 [Prabhjyot Singh] LivySparkSQLInterpreter should work in FIFO just like SparkSqlInterpreter
2f1c64c [Prabhjyot Singh] add in property file zeppelin.livy.concurrentSQL
@prabhjyotsingh prabhjyotsingh deleted the ZEPPELIN-1090 branch February 25, 2018 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants