Skip to content

ZEPPELIN-1063: fix flaky python interpreter test #1094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bzz wants to merge 5 commits into from
Closed

ZEPPELIN-1063: fix flaky python interpreter test #1094

bzz wants to merge 5 commits into from

Conversation

@bzz
Copy link
Member

@bzz bzz commented Jun 27, 2016 •
edited
Loading

What is this PR for?

fix flaky python interpreter test

What type of PR is it?

Bug Fix

Todos

  • cleanup test code
  • fix flaky open port check

What is the Jira issue?

ZEPPELIN-1063

How should this be tested?

mvn "-Dtest=org.apache.zeppelin.python.PythonInterpreterTest" test -pl python

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@bzz bzz changed the title ZEPPELIN-1063: fix flaky python interpreter test WIP - ZEPPELIN-1063: fix flaky python interpreter test Jun 27, 2016
@bzz bzz force-pushed the fix/python-tests/ZEPPELIN-1063 branch from 0de5320 to 67a2fe6 Compare June 27, 2016 12:23
@bzz bzz changed the title WIP - ZEPPELIN-1063: fix flaky python interpreter test ZEPPELIN-1063: fix flaky python interpreter test Jun 27, 2016
@bzz
Copy link
Member Author

bzz commented Jun 27, 2016 •
edited
Loading

Ready to be merged, \cc @minahlee @prabhjyotsingh for review.

Current CI failure is being taken care of under #1092

@bzz bzz force-pushed the fix/python-tests/ZEPPELIN-1063 branch from 67a2fe6 to b9de5a2 Compare June 27, 2016 15:28
@bzz
Copy link
Member Author

bzz commented Jun 27, 2016

Rebased on latest master, after #1092 got merged

@bzz
Copy link
Member Author

bzz commented Jun 28, 2016 •
edited
Loading

CI fails on Integration tests, and failure looks different from #1091 and #1092

Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 143.455 sec - in org.apache.zeppelin.integration.ZeppelinIT

Results :

Tests in error: 
  ParagraphActionsIT.testClearOutputButton:285->AbstractZeppelinIT.waitForParagraph:70->AbstractZeppelinIT.pollingWait:96 » Timeout

Tests run: 15, Failures: 0, Errors: 1, Skipped: 0

@prabhjyotsingh any chance you you seen this before?

@bzz
Copy link
Member Author

bzz commented Jun 28, 2016 •
edited
Loading

CI failure is not related and logged under ZEPPELIN-1073
Merging if there is no further disucssion

@asfgit asfgit closed this in 7951e6c Jun 28, 2016
@bzz bzz deleted the fix/python-tests/ZEPPELIN-1063 branch June 28, 2016 10:09
@prabhjyotsingh
Copy link
Contributor

prabhjyotsingh commented Jun 28, 2016

Yes, I've seen this, this happens when spark takes longer that 60sec to start up.
Will open up a new jira and fix this as well.

@prabhjyotsingh prabhjyotsingh mentioned this pull request Jun 30, 2016
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bzz @prabhjyotsingh