Skip to content

Conversation

@corneadoug
Copy link
Contributor

@corneadoug corneadoug commented Jun 24, 2016

What is this PR for?

This PR is fixing the bug by implementing a new layout for the Notebook Dropdown menu.
Reason being that setting a maximum height and having a scrollbar doesn't mix with having bootstrap submenus.

In term of dropdown layout, I think we have 2 options:

  • The one I implemented, a tree view similar to the one in the home page, I can probably uniform both of them later. One possible problem is the dropdown width getting bigger and bigger as we indent at each submenu.
  • The second one would not have any indent, but use a background color to show elements in the same folder (A grey that goes clearer as we go in the submenus)

screen shot 2016-06-25 at 1 42 41 am

Reworking the whole notebook list and dropdown will probably need a lot more work later (especially in term of refactoring and code cleaning), so I'm not sure where the scope of this PR should stop, especially with the release coming. I think the layout I implemented is fine to solve the immediate problem, and it is always possible to switch to the layout of option 2 later if we think it is best.

What type of PR is it?

Hot Fix

Todos

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-846

How should this be tested?

Just play with the folder structure and check the notebook dropdown

Screenshots (if appropriate)

openingfolder

notebookisrunnable

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@AhyoungRyu
Copy link
Contributor

@corneadoug Awesome! I tested and it works really well 👍

@Leemoonsoo
Copy link
Member

@corneadoug Tested and works well. Further work doesn't need to be addressed in this PR I think.

By the way, CI build is failing with error

INFO] src/components/expandCollapse/expandCollapse.directive.js
[INFO]   line 16  col 3   Missing "use strict" statement.
[INFO]   line 20  col 55  Strings must use singlequote.
[INFO]   line 21  col 54  Strings must use singlequote.
[INFO]   line 22  col 52  Strings must use singlequote.
[INFO]   line 24  col 46  Strings must use singlequote.
[INFO]   line 25  col 38  Strings must use singlequote.
[INFO]   line 31  col 10  Missing semicolon.
[INFO]   line 19  col 13  '$' is not defined.
[INFO]   line 20  col 18  '$' is not defined.
[INFO]   line 21  col 17  '$' is not defined.
[INFO]   line 22  col 17  '$' is not defined.
[INFO]   line 24  col 17  '$' is not defined.
[INFO]   line 25  col 19  '$' is not defined.
[INFO] 
[INFO] ✖ 13 problems

@corneadoug
Copy link
Contributor Author

@Leemoonsoo Just fixed that and a few HTML problems when minified.
Jshint didn't run during dev mode which is a bit fishy.

@minahlee
Copy link
Member

@corneadoug Can you rebase please?

@corneadoug corneadoug force-pushed the fix/longNavbarNotebookList branch from 5e435fe to 5a0fa09 Compare June 26, 2016 02:03
@corneadoug
Copy link
Contributor Author

@minahlee Rebased and ready

@minahlee
Copy link
Member

Awesome!! Works like a charm. Merge if there is no more discussion

@asfgit asfgit closed this in eca39e2 Jun 26, 2016
asfgit pushed a commit that referenced this pull request Jun 26, 2016
### What is this PR for?
This PR is fixing the bug by implementing a new layout for the Notebook Dropdown menu.
Reason being that setting a maximum height and having a scrollbar doesn't mix with having bootstrap submenus.

In term of dropdown layout, I think we have 2 options:
* The one I implemented, a tree view similar to the one in the home page, I can probably uniform both of them later. One possible problem is the dropdown width getting bigger and bigger as we indent at each submenu.
* The second one would not have any indent, but use a background color to show elements in the same folder (A grey that goes clearer as we go in the submenus)

<img width="691" alt="screen shot 2016-06-25 at 1 42 41 am" src="https://cloud.githubusercontent.com/assets/710411/16344155/2d387af0-3a76-11e6-87ba-9626d9f17fea.png">

Reworking the whole notebook list and dropdown will probably need a lot more work later (especially in term of refactoring and code cleaning), so I'm not sure where the scope of this PR should stop, especially with the release coming. I think the layout I implemented is fine to solve the immediate problem, and it is always possible to switch to the layout of option 2 later if we think it is best.

### What type of PR is it?
Hot Fix

### Todos
* [ ] - Rebase & Double Check the filtering and Notebook ordering after #1066

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-846

### How should this be tested?
Just play with the folder structure and check the notebook dropdown

### Screenshots (if appropriate)
![openingfolder](https://cloud.githubusercontent.com/assets/710411/16343658/583e1064-3a73-11e6-8607-bcdced587636.gif)

![notebookisrunnable](https://cloud.githubusercontent.com/assets/710411/16343663/5c10894c-3a73-11e6-9f54-c32136d3437a.gif)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Damien CORNEAU <[email protected]>

Closes #1081 from corneadoug/fix/longNavbarNotebookList and squashes the following commits:

223a7d3 [Damien CORNEAU] Fix Notebook dropdown css when on mobile
8170782 [Damien CORNEAU] Fix Notebook ordering in dropdown
5a0fa09 [Damien CORNEAU] fix jshint errors
a52b219 [Damien CORNEAU] Change Notebook dropdown style

(cherry picked from commit eca39e2)
Signed-off-by: Mina Lee <[email protected]>
asfgit pushed a commit that referenced this pull request Jun 27, 2016
### What is this PR for?
There were several changes in Zeppelin UI after #860, #1006, #1013, #1081 so update screenshot of documents accordingly.

### What type of PR is it?
Documentation

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: AhyoungRyu <[email protected]>
Author: Mina Lee <[email protected]>
Author: Mina Lee <[email protected]>

Closes #1089 from minahlee/doc/ZEPPELIN-1002 and squashes the following commits:

b237caf [Mina Lee] Merge pull request #1 from AhyoungRyu/doc/ZEPPELIN-1002/again
b18544a [AhyoungRyu] Update screenshot images in interpreters.md
add97fb [AhyoungRyu] Update screenshot images in notebookashomepage.md
cdaeb30 [AhyoungRyu] Update screenshot images in index.md
b21444a [AhyoungRyu] Update screenshot images in notebook_authorization.md
b23f7e4 [AhyoungRyu] Update screenshot images in dependencymanagement.md
e7a85f3 [AhyoungRyu] Update screenshot images in lens.md
cecd161 [AhyoungRyu] Update screenshot images in ignite.md
9f8cb71 [AhyoungRyu] Update screenshot images in elasticsearch.md
0c9a688 [AhyoungRyu] Hide dynamicinterpreterloading.md temporarily
a17f31f [Mina Lee] Update doc image in Explore Zeppelin UI page
asfgit pushed a commit that referenced this pull request Jun 27, 2016
### What is this PR for?
There were several changes in Zeppelin UI after #860, #1006, #1013, #1081 so update screenshot of documents accordingly.

### What type of PR is it?
Documentation

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: AhyoungRyu <[email protected]>
Author: Mina Lee <[email protected]>
Author: Mina Lee <[email protected]>

Closes #1089 from minahlee/doc/ZEPPELIN-1002 and squashes the following commits:

b237caf [Mina Lee] Merge pull request #1 from AhyoungRyu/doc/ZEPPELIN-1002/again
b18544a [AhyoungRyu] Update screenshot images in interpreters.md
add97fb [AhyoungRyu] Update screenshot images in notebookashomepage.md
cdaeb30 [AhyoungRyu] Update screenshot images in index.md
b21444a [AhyoungRyu] Update screenshot images in notebook_authorization.md
b23f7e4 [AhyoungRyu] Update screenshot images in dependencymanagement.md
e7a85f3 [AhyoungRyu] Update screenshot images in lens.md
cecd161 [AhyoungRyu] Update screenshot images in ignite.md
9f8cb71 [AhyoungRyu] Update screenshot images in elasticsearch.md
0c9a688 [AhyoungRyu] Hide dynamicinterpreterloading.md temporarily
a17f31f [Mina Lee] Update doc image in Explore Zeppelin UI page

(cherry picked from commit 09f0ebd)
Signed-off-by: Mina Lee <[email protected]>
@corneadoug corneadoug deleted the fix/longNavbarNotebookList branch August 24, 2016 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants