[MINOR] Small ui modification in notebook actionbar #1006
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minahlee
changed the title
Member
|
thanks for fixing this UI issues! LGTM |
Contributor
|
LGTM |
1 similar comment
Contributor
|
LGTM |
Contributor
|
LGTM 👍 |
Member
Author
|
I made one more change in table ascending, descending icon. Please review. |
Contributor
|
@minahlee Tested it and looks good :) |
Contributor
|
Merging if there is no more discussions |
minahlee
force-pushed
the
minor/ui_improve
branch
from
a60a8f6 to
15ef47e
Compare
Member
Author
|
Rebased master and updated screenshot in description. |
minahlee
force-pushed
the
minor/ui_improve
branch
2 times, most recently
from
085d290 to
25629a6
Compare
minahlee
force-pushed
the
minor/ui_improve
branch
from
25629a6 to
dc6dbe8
Compare
Member
Author
|
Selenium test passes after rebasing master. Merging if there is no more discussion |
asfgit
pushed a commit
that referenced
this pull request
Jun 22, 2016
### What is this PR for? Small ui improvements - Change keyboard shortcut icon - Modify commit container style - Change table asc/desc icon - Change interpreter create button font ### What type of PR is it? Improvement ### Screenshots (if appropriate) **Before** <img width="165" alt="screen shot 2016-06-13 at 12 55 41 pm" src="https://cloud.githubusercontent.com/assets/8503346/16021450/aebc14dc-3167-11e6-91d2-32fa8cd607af.png"> **After** <img width="164" alt="screen shot 2016-06-13 at 12 55 54 pm" src="https://cloud.githubusercontent.com/assets/8503346/16021451/b159c86a-3167-11e6-9311-b59cfffb3f6b.png"> **Before** <img width="254" alt="screen shot 2016-06-13 at 1 07 15 pm" src="https://cloud.githubusercontent.com/assets/8503346/16021480/d23661e2-3167-11e6-90f9-44340d5efe8f.png"> **After** <img width="252" alt="screen shot 2016-06-13 at 1 07 26 pm" src="https://cloud.githubusercontent.com/assets/8503346/16021482/d4cf92ac-3167-11e6-95a0-1eb28d0ed325.png"> **Before** <img width="82" alt="screen shot 2016-06-18 at 11 08 20 am" src="https://cloud.githubusercontent.com/assets/8503346/16172808/03295cec-3545-11e6-953a-c2c9a48ca841.png"> **After** <img width="82" alt="screen shot 2016-06-21 at 2 17 38 am" src="https://cloud.githubusercontent.com/assets/8503346/16224348/86c3f73e-3756-11e6-8b50-a4654d738d18.png"> **Before** <img width="383" alt="screen shot 2016-06-14 at 4 43 58 pm" src="https://cloud.githubusercontent.com/assets/8503346/16063627/60bb32de-324f-11e6-88a3-318575dcafc2.png"> **After** <img width="384" alt="screen shot 2016-06-14 at 4 43 20 pm" src="https://cloud.githubusercontent.com/assets/8503346/16063628/653316ba-324f-11e6-92ca-b559b62e234c.png"> **Before** <img width="113" alt="screen shot 2016-06-14 at 9 38 05 pm" src="https://cloud.githubusercontent.com/assets/8503346/16068142/54f5f6d6-3278-11e6-977a-1902a274c1f1.png"> **After** <img width="105" alt="screen shot 2016-06-14 at 9 37 34 pm" src="https://cloud.githubusercontent.com/assets/8503346/16068144/59344c70-3278-11e6-8038-ff3775cc432a.png"> ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? Screenshot needs to be updated Author: Mina Lee <[email protected]> Closes #1006 from minahlee/minor/ui_improve and squashes the following commits: dc6dbe8 [Mina Lee] Change interpreter create button font 72ff26e [Mina Lee] Change table asc desc icon bbca1ba [Mina Lee] Refine version control action UI 68619f8 [Mina Lee] Change keyboard shortcut icon (cherry picked from commit fd715c8) Signed-off-by: Mina Lee <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Jun 27, 2016
### What is this PR for? There were several changes in Zeppelin UI after #860, #1006, #1013, #1081 so update screenshot of documents accordingly. ### What type of PR is it? Documentation ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: AhyoungRyu <[email protected]> Author: Mina Lee <[email protected]> Author: Mina Lee <[email protected]> Closes #1089 from minahlee/doc/ZEPPELIN-1002 and squashes the following commits: b237caf [Mina Lee] Merge pull request #1 from AhyoungRyu/doc/ZEPPELIN-1002/again b18544a [AhyoungRyu] Update screenshot images in interpreters.md add97fb [AhyoungRyu] Update screenshot images in notebookashomepage.md cdaeb30 [AhyoungRyu] Update screenshot images in index.md b21444a [AhyoungRyu] Update screenshot images in notebook_authorization.md b23f7e4 [AhyoungRyu] Update screenshot images in dependencymanagement.md e7a85f3 [AhyoungRyu] Update screenshot images in lens.md cecd161 [AhyoungRyu] Update screenshot images in ignite.md 9f8cb71 [AhyoungRyu] Update screenshot images in elasticsearch.md 0c9a688 [AhyoungRyu] Hide dynamicinterpreterloading.md temporarily a17f31f [Mina Lee] Update doc image in Explore Zeppelin UI page
asfgit
pushed a commit
that referenced
this pull request
Jun 27, 2016
### What is this PR for? There were several changes in Zeppelin UI after #860, #1006, #1013, #1081 so update screenshot of documents accordingly. ### What type of PR is it? Documentation ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: AhyoungRyu <[email protected]> Author: Mina Lee <[email protected]> Author: Mina Lee <[email protected]> Closes #1089 from minahlee/doc/ZEPPELIN-1002 and squashes the following commits: b237caf [Mina Lee] Merge pull request #1 from AhyoungRyu/doc/ZEPPELIN-1002/again b18544a [AhyoungRyu] Update screenshot images in interpreters.md add97fb [AhyoungRyu] Update screenshot images in notebookashomepage.md cdaeb30 [AhyoungRyu] Update screenshot images in index.md b21444a [AhyoungRyu] Update screenshot images in notebook_authorization.md b23f7e4 [AhyoungRyu] Update screenshot images in dependencymanagement.md e7a85f3 [AhyoungRyu] Update screenshot images in lens.md cecd161 [AhyoungRyu] Update screenshot images in ignite.md 9f8cb71 [AhyoungRyu] Update screenshot images in elasticsearch.md 0c9a688 [AhyoungRyu] Hide dynamicinterpreterloading.md temporarily a17f31f [Mina Lee] Update doc image in Explore Zeppelin UI page (cherry picked from commit 09f0ebd) Signed-off-by: Mina Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Small ui improvements
What type of PR is it?
Improvement
Screenshots (if appropriate)
Before
After
Before
After
Before
After
Before
After
Before
After
Questions: