Skip to content

[ZEPPELIN-1020] Remove suggestion list on click #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
suvam97 wants to merge 3 commits into from
Closed

[ZEPPELIN-1020] Remove suggestion list on click #1027

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4372f49
remove suggestion list on click
Jun 16, 2016
c9ef56c
add angular.element in place of $
suvam97 Jun 17, 2016
29870cd
changed $ to angular.element
suvam97 Jun 18, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions zeppelin-web/src/app/notebook/notebook.controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -879,6 +879,7 @@ angular.module('zeppelinWebApp').controller('NotebookCtrl',

// function to find suggestion list on change
$scope.search = function(role) {
$('.userlist').show();

@corneadoug corneadoug Jun 18, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

angular.element?

convertToArray(role);
checkPreviousRole(role);
getChangedIndex();
Expand Down Expand Up @@ -950,5 +951,8 @@ angular.module('zeppelinWebApp').controller('NotebookCtrl',
$scope.suggestions = [];
};

angular.element(document).click(function(){
$('.userlist').hide();

@rranjan03 rranjan03 Jun 18, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

angular.element?

});

});