[ZEPPELIN-1020] Remove suggestion list on click #1027
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Can you change "$" to "angular.elements" |
Member
|
LGTM |
Contributor
Author
|
@prabhjyotsingh @r-kamath Thanks for the review! |
Contributor
|
@suvam97 Thanks for the contribution!! LGTM |
Contributor
|
Merging this if no more discussion. |
Contributor
|
I still see two line with '$' |
|
|
||
| // function to find suggestion list on change | ||
| $scope.search = function(role) { | ||
| $('.userlist').show(); |
Contributor
Author
|
@corneadoug @ravicodder Thanks for reviewing ! Somehow missed to make changes .. Final changes updated .. |
Contributor
|
Merging if there is no more discussions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
The suggestion list under note permissions for readers, writers & owners should hide on-click anywhere on the notebook.
What type of PR is it?
[Bug Fix]
Todos
What is the Jira issue?
ZEPPELIN-1020
How should this be tested?
1.Click on any field for setting permission for owners, readers & writers.
2.The suggestion list is displayed.
3.Now, click on any part of the notebook the suggestion list hides.
Screenshots (if appropriate)
BEFORE:
http://g.recordit.co/7Esaq245Tp.gif
AFTER
http://g.recordit.co/Rfgn5dONPz.gif
Questions: