Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested rfactor fix, update predicates as well as source. #3382

Merged
merged 3 commits into from
Jun 28, 2019
Merged

Nested rfactor fix, update predicates as well as source. #3382

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
28deaa1
Nested rfactor fix, update predicates as well as source.
csarofeen Jun 17, 2019
90b582f
Linter
csarofeen Jun 17, 2019
963f4ed
Syntax fix.
csarofeen Jun 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/schedule/schedule_dataflow_rewrite.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
*
* http://www.apache.org/licenses/LICENSE-2.0
*
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
Expand Down Expand Up @@ -756,12 +756,19 @@ Array<Tensor> Schedule::rfactor(const Tensor& tensor,
VarReplacer replacer(vsub);
Array<Expr> new_source = ir::UpdateArray(reduce->source,
[&replacer] (const Expr& e) { return replacer.Mutate(e); });

Array<Expr> orig_pred;
orig_pred.push_back(predicate);

Array<Expr> new_pred = ir::UpdateArray(orig_pred,
[&replacer] (const Expr& e) { return replacer.Mutate(e); });

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you create an array?
Just use
Expr new_pred = replacer.Mutate(predicate)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the syntax, updated.

std::vector<Expr> body;
for (size_t idx = 0; idx < reduce->source.size(); ++idx) {
body.emplace_back(Reduce::make(reduce->combiner,
new_source,
n->reduce_axis,
predicate,
new_pred[0],
idx));
}
n->body = Array<Expr>(body);
Expand Down