Nested rfactor fix, update predicates as well as source. #3382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution, @kazum @sgrechanik-h @derisavi @merrymercy please help to review this PR |
merrymercy
requested changes
Jun 20, 2019
|
|
||
| Array<Expr> new_pred = ir::UpdateArray(orig_pred, | ||
| [&replacer] (const Expr& e) { return replacer.Mutate(e); }); | ||
|
|
There was a problem hiding this comment.
Why do you create an array?
Just use
Expr new_pred = replacer.Mutate(predicate)
There was a problem hiding this comment.
Thank you for the syntax, updated.
|
@merrymercy Are there any other changes you'd like to see? #3444 is also similar if you would please review that one as well, simply wraps the predicate in |
merrymercy
approved these changes
Jun 28, 2019
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Jun 28, 2019
* Nested rfactor fix, update predicates as well as source. * Linter * Syntax fix.
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 30, 2019
* Nested rfactor fix, update predicates as well as source. * Linter * Syntax fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace reduction axis in predicates as well as the source code. Fixes: #3381