Skip to content

[BugFix][TVMScript] Fix the roundtripability of intrinsic pow #13692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 5, 2023
Merged

[BugFix][TVMScript] Fix the roundtripability of intrinsic pow #13692

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d50633b
Fix the roundtripability of pow intrinsic.
Jan 4, 2023
9e70c44
fix the lint.
Jan 4, 2023
42affc6
Fix the lint.
Jan 4, 2023
8ad0503
add tir.pow to make it consistent.
Jan 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions python/tvm/script/ir_builder/tir/ir.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1532,7 +1532,7 @@ def wrapped(*args, **kwargs):
nearbyint = _op_wrapper(_tir_op.nearbyint)
nextafter = _op_wrapper(_tir_op.nextafter)
popcount = _op_wrapper(_tir_op.popcount)
power = _op_wrapper(_tir_op.power)
pow = _op_wrapper(_tir_op.power) # pylint: disable=redefined-builtin
Copy link
Member

@junrushao junrushao Jan 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking if we could add a pow method to tvm/tir/op.py so that it could be consistent

Copy link
Contributor Author

@lightzhan-intellif lightzhan-intellif Jan 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

q_multiply_shift = _op_wrapper(_tir_op.q_multiply_shift)
q_multiply_shift_per_axis = _op_wrapper(_tir_op.q_multiply_shift_per_axis)
ret = _op_wrapper(_tir_op.ret)
Expand Down Expand Up @@ -1713,7 +1713,7 @@ def f():
"nearbyint",
"nextafter",
"popcount",
"power",
"pow",
"q_multiply_shift",
"q_multiply_shift_per_axis",
"ret",
Expand Down
9 changes: 9 additions & 0 deletions tests/python/unittest/test_tvmscript_roundtrip.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3550,6 +3550,14 @@ def func(A: T.Buffer[128, "float32"], C: T.Buffer[128, "float32"]):
return mod["main"]


def intrinsic_pow():
@T.prim_func
def func():
T.pow(T.float32(1), T.float32(1))

return func


ir_generator = tvm.testing.parameter(
opt_gemm_normalize,
opt_gemm_lower,
Expand Down Expand Up @@ -3607,6 +3615,7 @@ def func(A: T.Buffer[128, "float32"], C: T.Buffer[128, "float32"]):
elif_chain_with_else,
*nested_boolean_expressions(),
multi_env_threads,
intrinsic_pow,
)


Expand Down