Skip to content

[BugFix][TVMScript] Fix the roundtripability of intrinsic pow #13692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 5, 2023
Merged

[BugFix][TVMScript] Fix the roundtripability of intrinsic pow #13692

merged 4 commits into from
Jan 5, 2023
+34 −3

Conversation

@lightzhan-intellif
Copy link
Contributor

@lightzhan-intellif lightzhan-intellif commented Jan 4, 2023

Hi,
This is a bug fix discussed here. Any further suggestion is welcome.

cc @junrushao

@tvm-bot
Copy link
Collaborator

tvm-bot commented Jan 4, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

  • No users to tag found in teams: bugfix, tvmscript See #10317 for details

Generated by tvm-bot

@github-actions github-actions bot requested a review from junrushao January 4, 2023 02:28
@lightzhan-intellif lightzhan-intellif changed the title [BugFix][TVMScript] Fix the roundtripability of pow intrinsic. [BugFix][TVMScript] Fix the roundtripability of pow intrinsic Jan 4, 2023
@lightzhan-intellif lightzhan-intellif changed the title [BugFix][TVMScript] Fix the roundtripability of pow intrinsic [BugFix][TVMScript] Fix the roundtripability of intrinsic pow Jan 4, 2023
@lightzhan-intellif
Copy link
Contributor Author

lightzhan-intellif commented Jan 4, 2023

@tvm-bot rerun

Hzfengsy
Hzfengsy reviewed Jan 4, 2023
View reviewed changes
tests/python/unittest/test_tvmscript_roundtrip.py Outdated
assert "-> None" not in script


def test_pow_roundtripable():
Copy link
Member

@Hzfengsy Hzfengsy Jan 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please use the ir_generator to make tests consistent in this file?

Copy link
Contributor Author

@lightzhan-intellif lightzhan-intellif Jan 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay.

junrushao
junrushao approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please address comments from @Hzfengsy

@junrushao
Copy link
Member

junrushao commented Jan 4, 2023

BTW, there are some existing logics that depend on the python API tir.power, so please keep a copy as it is for backward compatibility

@lightzhan-intellif
Copy link
Contributor Author

lightzhan-intellif commented Jan 4, 2023

Do you mean that users can use both tir.pow and tir.power? I think it looks like a little bit confusing and redundant. How about we do not make any change to tir.power?

junrushao
junrushao reviewed Jan 4, 2023
View reviewed changes
python/tvm/script/ir_builder/tir/ir.py Outdated
nextafter = _op_wrapper(_tir_op.nextafter)
popcount = _op_wrapper(_tir_op.popcount)
power = _op_wrapper(_tir_op.power)
pow = _op_wrapper(_tir_op.power) # pylint: disable=redefined-builtin
Copy link
Member

@junrushao junrushao Jan 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking if we could add a pow method to tvm/tir/op.py so that it could be consistent

Copy link
Contributor Author

@lightzhan-intellif lightzhan-intellif Jan 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@Hzfengsy Hzfengsy merged commit 048028b into apache:main Jan 5, 2023
fzi-peccia pushed a commit to fzi-peccia/tvm that referenced this pull request Mar 27, 2023
@lightzhan-intellif @fzi-peccia
[BugFix][TVMScript] Fix the roundtripability of intrinsic pow (apache…
dd2525f 
…#13692)

* Fix the roundtripability of pow intrinsic.

* fix the lint.

* Fix the lint.

* add tir.pow to make it consistent.

Co-authored-by: lightzhan-intellif <[email protected]>
@ysh329 ysh329 mentioned this pull request Apr 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@junrushao junrushao junrushao approved these changes

@Hzfengsy Hzfengsy Hzfengsy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lightzhan-intellif @tvm-bot @junrushao @Hzfengsy