Skip to content

[TVMC] Only load extra targets when there are workspace pools #12253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 2, 2022
Merged

[TVMC] Only load extra targets when there are workspace pools #12253

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1924b41
[TVMC] Only load extra targets when there are workspace pools
lhutton1 Aug 1, 2022
330be7d
add test case
lhutton1 Aug 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions python/tvm/driver/tvmc/workspace_pools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,16 +161,6 @@ def workspace_pools_recombobulate(parsed, targets, extra_target):
"workspace_pools_target_burst_bytes",
]

# Load extra targets from CLI
additional_targets = []

for t in extra_target:
additional_targets.append(Target(t["raw"], host=targets[0].host or targets[0]))

target = targets + additional_targets
if targets[0].host:
target.append(targets[0].host)

workspace_pools = _split_pools_to_pool_names(parsed.workspace_pools)
if not workspace_pools:
return None
Expand All @@ -186,6 +176,16 @@ def workspace_pools_recombobulate(parsed, targets, extra_target):
for workspace_pool_param in WORKSPACE_POOL_TARGET_PARAMS
}

# Load extra targets from CLI
additional_targets = []

for t in extra_target:
additional_targets.append(Target(t["raw"], host=targets[0].host or targets[0]))

target = targets + additional_targets
if targets[0].host:
target.append(targets[0].host)

return WorkspaceMemoryPools(
[
WorkspacePoolInfo(
Expand Down