[TVMC] Only load extra targets when there are workspace pools #12253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After apache#11427, `tvmc compile` wouldn't work for external codegens that don't have a `Target` registered by `TVM_REGISTER_TARGET_KIND`. Such external codegens can be expected to have no workspace pools and may not always have a target associated as their implementation predates this mechanism. While it is likely a `Target` is specified for all external codegens in the future, we should still support external codegens without an associated `Target` until this is enforced. Change-Id: Ida8bf85ed1cafd301b9465641c66a5370d73c429
Mousius
requested changes
Aug 1, 2022
Member
Mousius
left a comment
Mousius
left a comment
There was a problem hiding this comment.
Can we get a test case to ensure we don't regress this in future?
Contributor
Author
|
sure, just added one |
lhutton1
force-pushed
the
fix-tvmc-compile
branch
from
df20deb to
f5a9326
Compare
Co-authored-by: Chris Sidebottom <[email protected]> Change-Id: I6a6bc9a023afd5a62a3c932dbc3ad535815b3963
lhutton1
force-pushed
the
fix-tvmc-compile
branch
from
f5a9326 to
330be7d
Compare
Mousius
approved these changes
Aug 2, 2022
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
…#12253) After apache#11427, `tvmc compile` wouldn't work for external codegens that don't have a `Target` registered by `TVM_REGISTER_TARGET_KIND`. Such external codegens can be expected to have no workspace pools and may not always have a target associated as their implementation predates this mechanism. While it is likely a `Target` is specified for all external codegens in the future, we should still support external codegens without an associated `Target` until this is enforced. Co-authored-by: Chris Sidebottom <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #11427,
tvmc compilewouldn't work for external codegens that don't have aTargetregistered byTVM_REGISTER_TARGET_KIND. This results in the error:Such external codegens can be expected to have no workspace pools and may not always have a target associated as their implementation predates this mechanism. While it is likely a
Targetis specified for all external codegens in the future, we should still support external codegens without an associatedTargetuntil this is enforced.cc @Mousius @areusch @dchauhan-arm @gromero @leandron