Skip to content

[relay] Fix missing virtual destructor #11601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vinx13 merged 1 commit into from
Jun 7, 2022
Merged

[relay] Fix missing virtual destructor #11601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/relay/transforms/compiler_function_utils.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,8 @@ class CallRewriter : public MixedModeMutator {

} // namespace

GlobalSymbolCache::~GlobalSymbolCache() = default;

GlobalVar ExistingGlobalSymbolCache::GetGlobalSymbol(const Function& function) {
Optional<String> opt_global_symbol = function->GetAttr<String>(tvm::attr::kGlobalSymbol);
ICHECK(opt_global_symbol.defined())
Expand Down
1 change: 1 addition & 0 deletions src/relay/transforms/compiler_function_utils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ namespace transforms {
*/
class GlobalSymbolCache {
public:
virtual ~GlobalSymbolCache();
Copy link
Member

@vinx13 vinx13 Jun 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: for simplicity, we have the implmentation inlined here

Suggested change
virtual ~GlobalSymbolCache();
virtual ~GlobalSymbolCache() = default;

Copy link
Contributor Author

@cconvey cconvey Jun 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: for simplicity, we have the implmentation inlined here

Thanks, I did consider that. Normally I prefer to keep as many details in the .cc file as possible, for better modularity.

virtual GlobalVar GetGlobalSymbol(const Function& function) = 0;
};

Expand Down