[relay] Fix missing virtual destructor #11601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
CC: @vinx13 @mbs-octoml |
Contributor
Author
|
FYI, I only noticed this because of a compiler warning from clang-10, not because of a manifested bug. |
Member
|
It might be better to have a virtual default destructor defined in the base class |
Add a default virtual destructor to `tvm::relay::transforms::GlobalSymbolCache`, so that correct destructors run when destroying subclass instances.
cconvey
force-pushed
the
fix-nonvirtual-dtor
branch
from
c34b468 to
e383338
Compare
Contributor
Author
|
@vinx13 : Mind giving this a Review? |
vinx13
reviewed
Jun 7, 2022
| */ | ||
| class GlobalSymbolCache { | ||
| public: | ||
| virtual ~GlobalSymbolCache(); |
Member
There was a problem hiding this comment.
nit: for simplicity, we have the implmentation inlined here
Suggested change
| virtual ~GlobalSymbolCache(); | |
| virtual ~GlobalSymbolCache() = default; |
Contributor
Author
There was a problem hiding this comment.
nit: for simplicity, we have the implmentation inlined here
Thanks, I did consider that. Normally I prefer to keep as many details in the .cc file as possible, for better modularity.
vinx13
approved these changes
Jun 7, 2022
Kathryn-cat
pushed a commit
to Kathryn-cat/tvm
that referenced
this pull request
Jun 10, 2022
Add a default virtual destructor to `tvm::relay::transforms::GlobalSymbolCache`, so that correct destructors run when destroying subclass instances.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing virtual destructor for derived class
tvm::relay::transforms::ExistingGlobalSymbolCache.Fixes a potential problem when deleting an instance
using a pointer-to-base-class.