[Meta Schedule] Fix testing issues for models with more than one inputs #11298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junrushao
reviewed
May 12, 2022
shingjan
force-pushed
the
fix_test_tune_script
branch
from
6bf8b60 to
14edabd
Compare
shingjan
commented
May 13, 2022
zxybazh
requested changes
May 17, 2022
Member
zxybazh
left a comment
zxybazh
left a comment
There was a problem hiding this comment.
Thanks for sending in the patch. I think there is not need to preserve the order of inputs, we can directly use a dictionary here with input name as key and input value as value.
shingjan
force-pushed
the
fix_test_tune_script
branch
from
01a582d to
7099d81
Compare
Author
|
@zxybazh comments addressed and rebased. Should be good for another look. Thanks! |
shingjan
force-pushed
the
fix_test_tune_script
branch
2 times, most recently
from
11669ea to
7dffe8a
Compare
added 12 commits
May 27, 2022 11:32
shingjan
force-pushed
the
fix_test_tune_script
branch
from
313eccf to
7922bcc
Compare
zxybazh
approved these changes
May 27, 2022
Member
zxybazh
left a comment
zxybazh
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for the effort!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to fix the issues in
tune_relay_meta_schedule.pyandtune_relay_auto_schedule.pyfor handling models with more than one input, likebert.cc @zxybazh @junrushao1994 @AndrewZhaoLuo