Skip to content

[Bugfix] Fix qnn.quantize type func with incomplete type #11124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
masahi merged 1 commit into from
May 20, 2022
Merged

[Bugfix] Fix qnn.quantize type func with incomplete type #11124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions src/relay/qnn/op/quantize.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,23 @@ bool QuantizeRel(const Array<Type>& types, int num_inputs, const Attrs& attrs,
axis = (axis < 0) ? ((rank > 0) ? data->shape.size() + axis : 0) : axis;

// If zero point and scale are scalar then axis doesnt matter.
bool scale_is_scalar = (types[1].as<TensorTypeNode>())->shape.size() == 0;
bool zp_is_scalar = (types[2].as<TensorTypeNode>())->shape.size() == 0;
bool scale_is_scalar, zp_is_scalar;

if (auto ttype = types[1].as<TensorTypeNode>()) {
scale_is_scalar = ttype->shape.size() == 0;
} else {
ICHECK(types[1].as<IncompleteTypeNode>())
<< "Quantize: expect to be TensorType but get " << types[1];
return false;
}

if (auto ttype = types[2].as<TensorTypeNode>()) {
zp_is_scalar = ttype->shape.size() == 0;
} else {
ICHECK(types[2].as<IncompleteTypeNode>())
<< "Quantize: expect to be TensorType but get " << types[2];
return false;
}

if (!(scale_is_scalar && zp_is_scalar)) {
ICHECK_LT(axis, rank > 0 ? rank : 1) << "axis " << quantize_attrs->axis << " is out of range";
Expand Down