[Bugfix] Fix qnn.quantize type func with incomplete type #11124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
also cc @anijain2305 @tqchen @comaniac |
mbrookhart
approved these changes
Apr 27, 2022
Contributor
Author
|
@mbrookhart @tqchen can this PR be merged? |
Contributor
|
It needs to pass CI first. Looks like you hit a flaky job? Maybe reabase and try again? |
hope51607
force-pushed
the
fix_quantize_rel
branch
from
87adca7 to
f287dd9
Compare
Contributor
Author
|
@mbrookhart it pass, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I get a segment fault when I try to apply merge_composite on a dynamic quantize model.
This seems to be because of the qnn.quantize type function cannot handle IncompleteType. This PR fixes this issue using the similar approach used by other type functions.
cc @mbrookhart