Skip to content

Conversation

@zxy844288792
Copy link

Add LinearRegressor operator support in relay onnx frontend.

"""Operator converter for LinearRegressor."""

@classmethod
def _impl_v1(cls, inputs, attr, params):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

document for parameter/return/function brief

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, given that all functions in this frontend do not have docstring, it should be fine for this PR to follow this convention for now.

Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@comaniac comaniac merged commit 48793f3 into apache:main Mar 10, 2022
@comaniac
Copy link
Contributor

Thanks @zxy844288792 @huajsj

pfk-beta pushed a commit to pfk-beta/tvm that referenced this pull request Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants