Skip to content

TEZ-4458:Upgrade Bouncy Castle to 1.70 due to high CVEs #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abstractdog merged 1 commit into from
Dec 2, 2022
Merged

TEZ-4458:Upgrade Bouncy Castle to 1.70 due to high CVEs #253

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@
<slf4j.version>1.7.36</slf4j.version>
<protobuf.version>3.21.1</protobuf.version>
<roaringbitmap.version>0.7.45</roaringbitmap.version>
<bouncycastle.version>1.70</bouncycastle.version>
<protoc.path>${env.PROTOC_PATH}</protoc.path>
<scm.url>scm:git:https://gitbox.apache.org/repos/asf/tez.git</scm.url>
<frontend-maven-plugin.version>1.8.0</frontend-maven-plugin.version>
Expand Down Expand Up @@ -758,7 +759,13 @@
<dependency>
<groupId>org.bouncycastle</groupId>
<artifactId>bcprov-jdk15on</artifactId>
<version>1.65</version>
<version>${bouncycastle.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.bouncycastle</groupId>
<artifactId>bcpkix-jdk15on</artifactId>

@abstractdog abstractdog Dec 2, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just wondering: what kind of test failure came when bcpkix wasn't included?

@mayankkunwar mayankkunwar Dec 2, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the test failure report: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-253/1/testReport/
Tests were complaining that they were not able to find org/bouncycastle/asn1/bsi/BSIObjectIdentifiers

@abstractdog abstractdog Dec 2, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, thanks for clarifying!

@mayankkunwar mayankkunwar Dec 2, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And with this I also checked that hadoop and other dependencies under TEZ dependency tree and they were using older version of bcpkix. So I thought to upgrade that as well

<version>${bouncycastle.version}</version>
<scope>test</scope>
</dependency>
<dependency>
Expand Down