Skip to content

TEZ-4406: Use Path.getFilesystem api to get the correct FileSystem object for given staging path #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rbalamohan merged 1 commit into from
Apr 25, 2022
Merged

TEZ-4406: Use Path.getFilesystem api to get the correct FileSystem object for given staging path #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tez-api/src/main/java/org/apache/tez/client/TezClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,14 +688,15 @@ private DAGClient submitDAGSession(DAG dag) throws TezException, IOException {
sessionAppId.toString()), TezConstants.TEZ_PB_PLAN_BINARY_NAME +
serializedSubmitDAGPlanRequestCounter.incrementAndGet());

try (FSDataOutputStream fsDataOutputStream = stagingFs.create(dagPlanPath, false)) {
FileSystem fs = dagPlanPath.getFileSystem(stagingFs.getConf());
try (FSDataOutputStream fsDataOutputStream = fs.create(dagPlanPath, false)) {
LOG.info("Send dag plan using YARN local resources since it's too large"
+ ", dag plan size=" + request.getSerializedSize()
+ ", max dag plan size through IPC=" + maxSubmitDAGRequestSizeThroughIPC
+ ", max IPC message size= " + amConfig.getTezConfiguration().getInt(
CommonConfigurationKeys.IPC_MAXIMUM_DATA_LENGTH, CommonConfigurationKeys.IPC_MAXIMUM_DATA_LENGTH_DEFAULT));
request.writeTo(fsDataOutputStream);
request = requestBuilder.clear().setSerializedRequestPath(stagingFs.resolvePath(dagPlanPath).toString()).build();
request = requestBuilder.clear().setSerializedRequestPath(fs.resolvePath(dagPlanPath).toString()).build();
}
}

Expand Down
5 changes: 3 additions & 2 deletions .../main/java/org/apache/tez/dag/api/client/rpc/DAGClientAMProtocolBlockingPBServerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,8 @@ public SubmitDAGResponseProto submitDAG(RpcController controller,
if (request.hasSerializedRequestPath()) {
// need to deserialize large request from hdfs
Path requestPath = new Path(request.getSerializedRequestPath());
try (FSDataInputStream fsDataInputStream = stagingFs.open(requestPath)) {
FileSystem fs = requestPath.getFileSystem(stagingFs.getConf());
try (FSDataInputStream fsDataInputStream = fs.open(requestPath)) {
CodedInputStream in =
CodedInputStream.newInstance(fsDataInputStream);
in.setSizeLimit(Integer.MAX_VALUE);
Expand All @@ -183,7 +184,7 @@ public SubmitDAGResponseProto submitDAG(RpcController controller,
}
String dagId = real.submitDAG(dagPlan, additionalResources);
return SubmitDAGResponseProto.newBuilder().setDagId(dagId).build();
} catch(TezException e) {
} catch(IOException | TezException e) {
throw wrapException(e);
}
}
Expand Down