Skip to content

Conversation

@guptanikhil007
Copy link
Contributor

What changes were proposed in this pull request?

Use Path.getFilesystem api to get the correct FileSystem object for given staging path

Why are the changes needed?

To prevent Wrong FS issue when the staging directory and warehouse root are on different storage locations and tez-conf size exceeds the IPC limit.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Manual tests.

@tez-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 19m 0s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗 mvndep 6m 11s Maven dependency ordering for branch
+1 💚 mvninstall 10m 59s master passed
+1 💚 compile 2m 14s master passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚 compile 2m 8s master passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 checkstyle 2m 8s master passed
+1 💚 javadoc 2m 10s master passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚 javadoc 1m 44s master passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+0 🆗 spotbugs 1m 53s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 3m 50s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for patch
+1 💚 mvninstall 1m 1s the patch passed
+1 💚 compile 1m 13s the patch passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚 javac 1m 13s the patch passed
+1 💚 compile 1m 3s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 javac 1m 3s the patch passed
+1 💚 checkstyle 0m 18s tez-api: The patch generated 0 new + 30 unchanged - 1 fixed = 30 total (was 31)
+1 💚 checkstyle 0m 25s The patch passed checkstyle in tez-dag
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 1m 7s the patch passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚 javadoc 1m 1s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 findbugs 2m 52s the patch passed
_ Other Tests _
+1 💚 unit 2m 26s tez-api in the patch passed.
+1 💚 unit 5m 8s tez-dag in the patch passed.
+1 💚 asflicense 0m 29s The patch does not generate ASF License warnings.
69m 28s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-201/1/artifact/out/Dockerfile
GITHUB PR #201
JIRA Issue TEZ-4406
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
uname Linux dcbe0adce207 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / 627f330
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-201/1/testReport/
Max. process+thread count 237 (vs. ulimit of 5500)
modules C: tez-api tez-dag U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-201/1/console
versions git=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@guptanikhil007
Copy link
Contributor Author

@rbalamohan and @abstractdog
Can you please help with the review?

@rbalamohan
Copy link
Contributor

Thanks for the patch @guptanikhil007. Looks like this is a corner case scenario with large IPC limits.

Patch looks good to me. +1

@guptanikhil007
Copy link
Contributor Author

@rbalamohan Can you please merge this as well?
I don't have commit access.

@rbalamohan rbalamohan merged commit 9f8d6fb into apache:master Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants