Skip to content

Conversation

@abstractdog
Copy link
Contributor

No description provided.

@tez-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 15m 54s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1 💚 mvninstall 12m 58s master passed
+1 💚 compile 0m 25s master passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 compile 0m 25s master passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 checkstyle 0m 53s master passed
+1 💚 javadoc 0m 34s master passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 0m 20s master passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+0 🆗 spotbugs 1m 1s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 0m 58s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 25s the patch passed
+1 💚 compile 0m 16s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javac 0m 16s the patch passed
+1 💚 compile 0m 14s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 javac 0m 14s the patch passed
+1 💚 checkstyle 0m 9s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 0m 12s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 0m 11s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 findbugs 0m 36s the patch passed
_ Other Tests _
+1 💚 unit 2m 38s tez-aux-services in the patch passed.
+1 💚 asflicense 0m 12s The patch does not generate ASF License warnings.
38m 9s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-163/1/artifact/out/Dockerfile
GITHUB PR #163
JIRA Issue TEZ-4351
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
uname Linux d9513175a4de 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / f39a51e
Default Java Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-163/1/testReport/
Max. process+thread count 1371 (vs. ulimit of 5500)
modules C: tez-plugins/tez-aux-services U: tez-plugins/tez-aux-services
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-163/1/console
versions git=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@abstractdog
Copy link
Contributor Author

could you please take a look @rbalamohan, @jteagles? very small patch, unit test included

Copy link
Contributor

@jteagles jteagles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. This will need to go to branch-0.9 as well since TEZ-4157 is in master and branch-0.9 I believe.

@abstractdog
Copy link
Contributor Author

thanks for the review @jteagles, I'm merging, I'll check if we need this on branch-0.9, not because of TEZ-4157, because that wasn't the root cause actually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants