Skip to content

Conversation

@jteagles
Copy link
Contributor

Co-authored-by: Sreenath Somarajapuram [email protected]

@tez-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 12m 38s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 15m 29s master passed
+1 💚 javadoc 0m 47s master passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 0m 20s master passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
_ Patch Compile Tests _
+1 💚 mvninstall 1m 30s the patch passed
+1 💚 jshint 39m 52s There were no new jshint issues.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 0m 18s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 0m 22s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
_ Other Tests _
+1 💚 unit 2m 29s tez-ui in the patch passed.
+1 💚 asflicense 0m 27s The patch does not generate ASF License warnings.
75m 15s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-146/1/artifact/out/Dockerfile
GITHUB PR #146
Optional Tests dupname asflicense javac javadoc unit jshint
uname Linux 3e7f0724518d 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / e2c4ee0
Default Java Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-146/1/testReport/
Max. process+thread count 93 (vs. ulimit of 5500)
modules C: tez-ui U: tez-ui
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-146/1/console
versions git=2.25.1 maven=3.6.3 jshint=2.12.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@abstractdog
Copy link
Contributor

patch looks very similar to em-helpers import, LGTM
+1

@abstractdog abstractdog self-requested a review August 26, 2021 08:29
@abstractdog
Copy link
Contributor

1 minor thing before merging, please take a look at this comment: #147 (comment)

@jteagles jteagles merged commit 0ccf440 into apache:master Aug 26, 2021
@jteagles jteagles deleted the TEZ-4329 branch August 26, 2021 14:14
jteagles added a commit to jteagles/tez that referenced this pull request Oct 25, 2021
Co-authored-by: Sreenath Somarajapuram <[email protected]>
(cherry picked from commit 0ccf440)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants