Skip to content

Conversation

@dpgaspar
Copy link
Member

SUMMARY

Bug introduced on #9619, URL for druid datasources rendering name instead of explore_url

TEST PLAN

  • Create a druid cluster and datasource
  • Create a chart for the previous create druid datasource
  • Assert that the rendered URL for the datasource on the charts list links to the druid datasource

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2020

Codecov Report

Merging #9839 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9839   +/-   ##
=======================================
  Coverage   71.02%   71.02%           
=======================================
  Files         583      583           
  Lines       30615    30615           
  Branches     3162     3162           
=======================================
  Hits        21745    21745           
  Misses       8759     8759           
  Partials      111      111           
Flag Coverage Δ
#cypress 53.54% <ø> (-0.01%) ⬇️
#javascript 59.29% <ø> (ø)
#python 71.27% <0.00%> (ø)
Impacted Files Coverage Δ
superset/models/slice.py 83.78% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ca6ed7...2f3b0f4. Read the comment docs.

@dpgaspar dpgaspar merged commit 61ebb9b into apache:master May 21, 2020
@dpgaspar dpgaspar deleted the fix/api-dataset-druid branch May 21, 2020 09:45
pkdotson pushed a commit to preset-io/superset that referenced this pull request May 26, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.37.0 First shipped in 0.37.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.37.0 First shipped in 0.37.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants