perf(dashboards): improve API performance for dashboards #9704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
villebro
approved these changes
May 5, 2020
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
SUMMARY
Uses new FAB 2.3.4 that improves performance on table joins. Again like stated on #9619, when using properties has virtual columns, we should to make sure that the method references columns already referenced on
list_columnsor SQLAlchemy will issue a new queryNote: We should merge #9703 first
Before:
[stats_logger] (timing) DashboardRestApi.get_list.time 110ms - 150ms
After:
[stats_logger] (timing) DashboardRestApi.get_list.time 15ms - 30ms
ADDITIONAL INFORMATION
REVIEWERS
@willbarrett @nytai