Skip to content

Clickable checkbox labels #8534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mistercrunch merged 3 commits into from
Nov 12, 2019
Merged

Clickable checkbox labels #8534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b61e527
passing onClick prop to header with the existing onChange method.
rusackas Nov 8, 2019
b34052f
basic test checking that label click fires the onChange method.
rusackas Nov 8, 2019
0cee9aa
cleaning up stuff caught by linting.
rusackas Nov 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion superset/assets/spec/javascripts/explore/components/CheckboxControl_spec.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
/* eslint-disable no-unused-expressions */
import React from 'react';
import sinon from 'sinon';
import { shallow } from 'enzyme';
import { shallow, mount } from 'enzyme';

import CheckboxControl from '../../../../src/explore/components/controls/CheckboxControl';
import ControlHeader from '../../../../src/explore/components/ControlHeader';
Expand All @@ -46,4 +46,16 @@ describe('CheckboxControl', () => {
const headerWrapper = controlHeader.shallow();
expect(headerWrapper.find(Checkbox)).toHaveLength(1);
});

it('Checks the box when the label is clicked', () => {
const fullComponent = mount(<CheckboxControl {...defaultProps} />);

const spy = sinon.spy(fullComponent.instance(), 'onChange');

fullComponent.instance().forceUpdate();

fullComponent.find('label span').last().simulate('click');

expect(spy.calledOnce).toBe(true);
});
});
1 change: 1 addition & 0 deletions superset/assets/src/explore/components/controls/CheckboxControl.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ export default class CheckboxControl extends React.Component {
<ControlHeader
{...this.props}
leftNode={this.renderCheckbox()}
onClick={this.onChange.bind(this)}
/>
);
}
Expand Down