Clickable checkbox labels#8534
Merged
mistercrunch merged 3 commits intoapache:masterfrom Nov 12, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8534 +/- ##
==========================================
+ Coverage 66.72% 66.72% +<.01%
==========================================
Files 449 449
Lines 22696 22696
Branches 2366 2366
==========================================
+ Hits 15143 15145 +2
+ Misses 7415 7413 -2
Partials 138 138
Continue to review full report at Codecov.
|
graceguo-supercat
pushed a commit
that referenced
this pull request
Nov 13, 2019
* passing onClick prop to header with the existing onChange method. * basic test checking that label click fires the onChange method. * cleaning up stuff caught by linting.
Member
Author
|
🏷 preset-io |
mistercrunch
added
🏷️ bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
Checkbox controls required sniping the actual checkbox. This PR lets you click the labels to toggle the checkbox.
if not applicable -->
TEST PLAN
A pretty basic Jest test was added.
ADDITIONAL INFORMATION
REVIEWERS
@mistercrunch ?