[WIP][feature] Dashboard filter scope selector modal#8403
Closed
graceguo-supercat wants to merge 1 commit intomasterfrom
Closed
[WIP][feature] Dashboard filter scope selector modal#8403graceguo-supercat wants to merge 1 commit intomasterfrom
graceguo-supercat wants to merge 1 commit intomasterfrom
Conversation
graceguo-supercat
force-pushed
the
scope-selector-modal
branch
from
7d7f314 to
1609403
Compare
Author
|
sorry, this PR set to wrong branch. please use #8404 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CATEGORY
SUMMARY
This is part 1 for Dashboard Scoped Filter project. This PR is for a new UI module and components: filter scope selector modal. It covers the UI/UX that display/select scope (tabs and charts) for any search field. Update dashboard redux state and persist filter scope settings to backend, will be covered in another PR.
Before: set filter immune in dashboard metadata
After: single-edit mode, edit one filter field
multi-edit mode, edit all selected filter fields:
search chart name and set scope
Implementation
TEST PLAN
ADDITIONAL INFORMATION
REVIEWERS
@etr2460 @williaster @mistercrunch @kenchendesign