feat: bump superset-ui dependencies to v0.12 and plugins to v0.11#8115
Merged
kristw merged 6 commits intoapache:masterfrom Aug 27, 2019
Merged
feat: bump superset-ui dependencies to v0.12 and plugins to v0.11#8115kristw merged 6 commits intoapache:masterfrom
kristw merged 6 commits intoapache:masterfrom
Conversation
superset/assets/package.json
Outdated
| }, | ||
| "homepage": "https://superset.apache.org/", | ||
| "dependencies": { | ||
| "@airbnb/lunar": "~2.23.0", |
Member
There was a problem hiding this comment.
How is this used / referenced?
Contributor
Author
There was a problem hiding this comment.
This is used by the plugin-chart-table. There was an issue with the newest version of lunar (2.24) so I have to pin this until it is resolved.
Member
|
Thanks @kristw , will implement |
etr2460
approved these changes
Aug 27, 2019
Member
etr2460
left a comment
There was a problem hiding this comment.
lgtm, thanks for finishing up this upgrade!
6d89688 to
5abe936
Compare
Codecov Report
@@ Coverage Diff @@
## master #8115 +/- ##
==========================================
- Coverage 73.61% 65.86% -7.76%
==========================================
Files 114 485 +371
Lines 11972 22943 +10971
Branches 0 2541 +2541
==========================================
+ Hits 8813 15111 +6298
- Misses 3159 7698 +4539
- Partials 0 134 +134
Continue to review full report at Codecov.
|
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
@superset-uipackages to0.12@superset-ui/queryis split from@superset-ui/chartdurationFormattercc: @villebro@superset-ui-pluginspackages to0.11@superset-ui@0.12filter_box,time_tableanddeck.glplugins that reside in this main repo to conform to the new APIs. (See migration guide from this PR)BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
REVIEWERS
@etr2460