This repository was archived by the owner on Jun 25, 2020. It is now read-only.
Conversation
Codecov Report
@@ Coverage Diff @@
## master #183 +/- ##
=======================================
Coverage 34.25% 34.25%
=======================================
Files 12 12
Lines 216 216
Branches 21 21
=======================================
Hits 74 74
Misses 132 132
Partials 10 10
Continue to review full report at Codecov.
|
|
Deploy preview for superset-ui-plugins ready! Built with commit 29c098e |
etr2460
approved these changes
Aug 26, 2019
Contributor
etr2460
left a comment
etr2460
left a comment
There was a problem hiding this comment.
one question about NOOP, otherwise lgtm!
| import isTruthy from './utils/isTruthy'; | ||
| import { formatLabel } from './utils'; | ||
|
|
||
| function NOOP() {} |
Contributor
There was a problem hiding this comment.
is this preferred to const NOOP = () => {};? I find defining a function like this as a constant at the top of the file a bit more readable
2 tasks
Yria
added a commit
to dooub/superset-ui-plugins
that referenced
this pull request
Oct 28, 2019
* commit '0916c62e98b7cf9f30212cb155a00748db29f043': (171 commits) v0.11.0 feat: upgrade @superset-ui to v0.12 (apache-superset#183) v0.10.46 fix(force to publish new version): force to publish new version v0.10.45 fix(fix issues in superset): fix issues in superset v0.10.44 fix: move react to table peerdependency (apache-superset#179) v0.10.43 docs: update thumbnails (apache-superset#178) v0.10.42 fix(fix types): fix types test(added more tests): added more tests fix(tablevis): update datatable change docs: update change log refactor(address code review comments): address code review comments v0.10.41 feat: update type for line chart series (apache-superset#175) build(bump the verions): bump the verions build(migrate to lunar 2*): migrate to lunar 2* ... # Conflicts: # packages/superset-ui-legacy-plugin-chart-pivot-table/package.json # packages/superset-ui-legacy-plugin-chart-table/package.json # packages/superset-ui-legacy-plugin-chart-table/src/Table.js # packages/superset-ui-legacy-preset-chart-nvd3/package.json # packages/superset-ui-preset-chart-xy/src/Line/Encoder.ts # packages/superset-ui-preset-chart-xy/src/encodeable/AbstractEncoder.ts
nytai
pushed a commit
to preset-io/superset-ui-plugins
that referenced
this pull request
Apr 27, 2020
nytai
pushed a commit
to preset-io/superset-ui-plugins
that referenced
this pull request
Apr 27, 2020
* build: update dependencies * feat: replace payload with queryData * feat: replace payload with queryData * fix: rename hooks * fix: types from query package * fix: more typings * docs: update readme * fix: import query * fix: change NOOP to const * fix: update dependency versions
lexisstv
pushed a commit
to utrace-ltd/superset-ui-plugins
that referenced
this pull request
Jun 1, 2020
* build: update dependencies * feat: replace payload with queryData * feat: replace payload with queryData * fix: rename hooks * fix: types from query package * fix: more typings * docs: update readme * fix: import query * fix: change NOOP to const * fix: update dependency versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💔 Breaking Changes:
Many changes to the plugins are required to make them compatible with
@superset-ui/xxxv0.12. After the changes in this PR, these plugin packages are no longer backward compatible with@superset-ui/xxxv0.10orv0.11, therefore worth calling out as breaking changes.What were changed?
1. Version bump dependencies
2. Update
transformProps.(js|ts)Several fields in
chartPropsare changed.payloadtoqueryDatafilterstoinitialValuesonAddFilter,onError,setControlValue,setTooltipfromhooks3. Update types imported from
@superset-ui/chart@superset-ui/chartand moved into the new package@superset-ui/queryinv0.124. Update storybooks and READMEs
Update
<SuperChart>propsTest
I have verified all stories in storybook and they work like before.
Note: The legacy
tableandpivot_tableexamples are not working due to wrong webpack configuration which I will address in another PR.