Skip to content

Conversation

@graceguo-supercat
Copy link

Fix #4314.

  • fix check filters change logic, should not refresh the filter_box which had changed.
  • should show chart when loading is completed

2. should show chart after loading completed
@mistercrunch
Copy link
Member

LGTM

@graceguo-supercat graceguo-supercat merged commit e965f95 into apache:master Feb 5, 2018
graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this pull request Feb 5, 2018
2. should show chart after loading completed

(cherry picked from commit e965f95)
@graceguo-supercat graceguo-supercat deleted the gg-FixRemoveNodeError branch February 5, 2018 20:15
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
2. should show chart after loading completed
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
2. should show chart after loading completed
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.23.0 First shipped in 0.23.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.23.0 First shipped in 0.23.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Interactive with filter_box when it is loading, Dashboard throws JS error

2 participants